Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help users understand more clearly when the store is misconfigured #274

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Help users understand more clearly when the store is misconfigured #274

merged 1 commit into from
Mar 9, 2018

Conversation

grzuy
Copy link
Collaborator

@grzuy grzuy commented Feb 1, 2018 •
edited
Loading

Instead of throwing

undefined method `increment' for nil:NilClass

raise

Rack::Attack::MissingStoreError

or

Rack::Attack::MisconfiguredStoreError

to aid users in debugging

@grzuy grzuy added this to the 5.1.0 milestone Mar 9, 2018
@grzuy grzuy merged commit 922917d into rack:master Mar 9, 2018
@grzuy grzuy deleted the help_debug_cache_issues branch March 9, 2018 13:28
@grzuy grzuy mentioned this pull request Mar 15, 2018
Closed
@grzuy
Copy link
Collaborator Author

grzuy commented Mar 15, 2018

Helps with #300

@grzuy grzuy mentioned this pull request Mar 16, 2018
Closed
6 tasks
@dependabot-preview dependabot-preview bot mentioned this pull request Mar 17, 2018
Closed
@annaswims annaswims mentioned this pull request Dec 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@grzuy