-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Action to create Docker image #392
Github Action to create Docker image #392
Conversation
Hi @tschumpr, thanks for your contribution! I was trying to use this image https://github.com/GeoWerkstatt/stac-browser/pkgs/container/stac-browser (image Same configuration is working for me when using an image built by myself from https://github.com/radiantearth/stac-browser/tree/ae7e5cf1c98dc7cd9c03f5e1a4d333556e345b8e. |
After checking it twice, now I see that your image is trying to get resources from path Maybe you set this path prefix at build time for |
@pedroetb We had to do the adjustment of |
Wow @tschumpr that was fast! Nice, already tested and working great for me, thanks! When this PR gets merged (I hope so), I will migrate to |
What do my Docker magicians think about this? Sounds like a good idea, I just don't have a clue about it myself. @geospatial-jeff @waystilos @constantinius |
lgtm! I just had one comment but other than that, it looks good. Happy new year! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Do we want to have the 'v' prefix from the tag name for the version?
Looks good to me. Left 3 minor comments. Once these are resolved, we I can merge this @tschumpr. Thanks for the PR. Do I need to enable Packages on GitHub or something like that? |
Co-authored-by: Matthias Mohr <[email protected]>
Co-authored-by: Matthias Mohr <[email protected]>
Thanks, let's see how it goes... |
* Add action to build image on release Co-authored-by: Matthias Mohr <[email protected]>
This action builds a docker image whenever a new release is published. The image is named after the release tag, e.g. tag v.3.1.0-test results in the image 3.1.0.-test.