Skip to content

Commit

Permalink
Move Directory.Packages.Helix.props to RepoTesting
Browse files Browse the repository at this point in the history
.. as it is only used by that.
  • Loading branch information
radical committed Jul 16, 2024
1 parent c532b48 commit 1fe6b17
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tests/Aspire.EndToEnd.Tests/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ The following changes need to be made to when adding a new component:

* Add a new `TestResourceNames` [enum entry](../testproject/Common/TestResourceNames.cs).
* Add ProjectReference to the new resource/component from the [TestProject.AppHost](../testproject/TestProject.AppHost/TestProject.AppHost.csproj) and [TestProject.IntegrationServiceA](../testproject/TestProject.IntegrationServiceA/TestProject.IntegrationServiceA.csproj) projects.
* Add PackageVersion entries to the new packages in [Directory.Packages.Helix.props](../Shared/WorkloadTesting/Directory.Packages.Helix.props)
* Add PackageVersion entries to the new packages in [Directory.Packages.Helix.props](../Shared/RepoTesting/Directory.Packages.Helix.props)
* Add entries to the Program.cs of both the AppHost and IntegrationServiceA projects.
* Add a test in [IntegrationServicesTests](../Aspire.EndToEnd.Tests/IntegrationServicesTests.cs)
* If the component's container starts in a reasonable time, the new test can just be a new `[InlineData]` entry to the existing `VerifyComponentWorks` test.
Expand Down
2 changes: 1 addition & 1 deletion tests/Shared/RepoTesting/Aspire.Testing.Repo.targets
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@

<!-- Needed to override aspire package versions, and provide versions for other packages -->
<None Include="$(GeneratedPackagesVersionsPropsPath)" Link="$(DeployOutsideOfRepoSupportFilesRelativeDir)Directory.Packages.Versions.props" CopyToOutputDirectory="PreserveNewest" />
<None Include="$(TestsSharedDir)WorkloadTesting\data\Directory.Packages.Helix.props" Link="$(DeployOutsideOfRepoSupportFilesRelativeDir)%(FileName)%(Extension)" CopyToOutputDirectory="PreserveNewest" />
<None Include="$(TestsSharedRepoTestingDir)Directory.Packages.Helix.props" Link="$(DeployOutsideOfRepoSupportFilesRelativeDir)%(FileName)%(Extension)" CopyToOutputDirectory="PreserveNewest" />

<!-- nuget.config to resolve built packages from artifacts -->
<None Include="$(TestsSharedDir)nuget-with-package-source-mapping.config" Link="$(DeployOutsideOfRepoSupportFilesRelativeDir)nuget.config" CopyToOutputDirectory="PreserveNewest" />
Expand Down

0 comments on commit 1fe6b17

Please sign in to comment.