Skip to content

Commit

Permalink
Use dotnet#37669 as the issue, based on feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
radical committed Nov 2, 2021
1 parent 9725bed commit a2a22a8
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public static void NamedCreateMethods_NullInput()
// The returned types on .NET Framework can differ when the machine is in FIPS mode.
// So check hash algorithms via a more complicated manner.
[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61099", TestPlatforms.Browser)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/37669", TestPlatforms.Browser)]
[InlineData("MD5", typeof(MD5))]
[InlineData("http://www.w3.org/2001/04/xmldsig-more#md5", typeof(MD5))]
[InlineData("System.Security.Cryptography.HashAlgorithm", typeof(SHA1))]
Expand Down Expand Up @@ -68,7 +68,7 @@ public static void NamedHashAlgorithmCreate(string identifier, Type baseType)
}

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61099", TestPlatforms.Browser)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/37669", TestPlatforms.Browser)]
[InlineData("System.Security.Cryptography.HMAC", typeof(HMACSHA1))]
[InlineData("System.Security.Cryptography.KeyedHashAlgorithm", typeof(HMACSHA1))]
[InlineData("System.Security.Cryptography.HMACSHA1", typeof(HMACSHA1))]
Expand Down Expand Up @@ -101,7 +101,7 @@ public static void NamedKeyedHashAlgorithmCreate(string identifier, Type actualT
}

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61099", TestPlatforms.Browser)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/37669", TestPlatforms.Browser)]
[InlineData("AES", typeof(Aes))]
#pragma warning disable SYSLIB0022 // Rijndael types are obsolete
[InlineData("Rijndael", typeof(Rijndael))]
Expand All @@ -127,7 +127,7 @@ public static void NamedSymmetricAlgorithmCreate(string identifier, Type baseTyp
}

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61099", TestPlatforms.Browser)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/37669", TestPlatforms.Browser)]
[InlineData("RSA", typeof(RSA))]
[InlineData("System.Security.Cryptography.RSA", typeof(RSA))]
[InlineData("ECDsa", typeof(ECDsa))]
Expand All @@ -141,7 +141,7 @@ public static void NamedAsymmetricAlgorithmCreate(string identifier, Type baseTy
}

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61099", TestPlatforms.Browser)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/37669", TestPlatforms.Browser)]
[InlineData("DSA", typeof(DSA))]
[InlineData("System.Security.Cryptography.DSA", typeof(DSA))]
[SkipOnPlatform(PlatformSupport.MobileAppleCrypto, "DSA is not available")]
Expand All @@ -164,7 +164,7 @@ public static void NamedAsymmetricAlgorithmCreate_DSA_NotSupported(string identi
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61099", TestPlatforms.Browser)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/37669", TestPlatforms.Browser)]
public static void NamedCreate_Mismatch()
{
Assert.Throws<InvalidCastException>(() => AsymmetricAlgorithm.Create("SHA1"));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public async Task VerifyComputeHashAsync(int size)
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61099", TestPlatforms.Browser)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/37669", TestPlatforms.Browser)]
public async Task ComputeHashAsync_SupportsCancellation()
{
using (CancellationTokenSource cancellationSource = new CancellationTokenSource(100))
Expand Down

0 comments on commit a2a22a8

Please sign in to comment.