This repository has been archived by the owner on Feb 28, 2021. It is now read-only.
cli: Move from 'local account' to 'key-pair' #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeSandwich
approved these changes
May 1, 2020
NunoAlexandre
force-pushed
the
cli/key-pairs
branch
from
a56992a
to
49f9a6f
Compare
|
Thanks, @CodeSandwich. I have included your rewording in the first commit. |
NunoAlexandre
force-pushed
the
cli/key-pairs
branch
from
49f9a6f
to
297bd0a
Compare
NunoAlexandre
force-pushed
the
cli/key-pairs
branch
from
297bd0a
to
a656ec4
Compare
- Disambiguate the terminology 'account' and 'local account' by now calling local accounts key-pairs; - Move key-pair related commands to a new command group 'key-pair' - Update the README and the CHANGELOG - Migrate the local accounts.json file to key-pairs.json
To follow the latest convention on error display, where we have a single place printing all the source errors recursively. As it is now, the source error is printed twice, first inlined and a second time beneath.
NunoAlexandre
force-pushed
the
cli/key-pairs
branch
from
a656ec4
to
ad2c2a0
Compare
|
@geigerzaehler thanks for your review! Can you have another look? |
| if !path.exists() { | ||
| std::fs::write(path, b"{}").map_err(WritingError::IO)?; | ||
| } | ||
|
|
||
| Ok(path_buf) | ||
| } | ||
|
|
||
| fn build_path(filename: &str) -> Result<PathBuf, Error> { | ||
| let dir = dir()?; |
There was a problem hiding this comment.
Suggestion: dir is only used here. might make sense just to inline it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #414
calling local accounts key-pairs;
Test required:
Pull this branch and run either of the
key-pairsub-commands. Doing so will trigger a migration to rename theaccounts.jsonfile tokey-pairs.json. I faced a permissions issue myself, where theaccounts.jsonfile permissions seem to have been changed somehow (recent system upgrade?).Note: Docs companion PR: radicle-dev/registry.radicle.xyz#37