This repository has been archived by the owner on Aug 1, 2022. It is now read-only.
feat(proxy): org project list endpoint #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeBrei
changed the title
|
Added an issue in the registry to retrieve the projects of an org/user more direct. |
xla
approved these changes
May 7, 2020
proxy/src/http/project.rs
Outdated
| @@ -223,8 +224,18 @@ mod handler { | |||
| let fake_fee: Balance = 100; | |||
|
|
|||
| let mut reg = registry.write().await; | |||
| let maybe_coco_id = match input.maybe_coco_id { | |||
There was a problem hiding this comment.
You should be able to use Option::map to transform the Some value and return None if no value is present.
proxy/src/registry.rs
Outdated
| Project { | ||
| name: project.name, | ||
| org_id: project.org_id, | ||
| maybe_project_id: if let [] = metadata_vec[..] { |
There was a problem hiding this comment.
The is_empty would make this more readable.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Endpoint to return all projects registered under an org.
Projectinstead of only the project name (*)GET orgs/<id>/projects(*) Open issue/dependency:
Noneis always passed as themaybe_project_idin the proxy. In order to show any other info beside the name of the project, we need to pass the project id.Solves part of #277