Updated code to compile with actual flex and gcc #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flex function 'input' was reported unused and -Werror therefore terminated this as error, Signed-off-by: Carsten Schlote <[email protected]>
Signed-off-by: Carsten Schlote <[email protected]>
Signed-off-by: Carsten Schlote <[email protected]>
Signed-off-by: Carsten Schlote <[email protected]>
By defining YY_NO_INPUT the unused input function is no longer created. -Werror is now reenabled for dev builds again. Signed-off-by: Carsten Schlote <[email protected]>
Added code to check for a valid return value of asprintf(). Now the logger is only called, when asprintf() completed successfully. This also silences a warning about unused return values. Signed-off-by: Carsten Schlote <[email protected]>
Signed-off-by: Carsten Schlote <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to investigate SSE channels and tested this code. To get it compiling, I fixed up some things.