Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update az login on LRT to run always #7496

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

sk593
Copy link
Contributor

@sk593 sk593 commented Apr 11, 2024

Description

Minor update to azure cli login in LRT: #7491

Adding this step to run always in case previous steps fail

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).
  • This pull request adds or changes features of Radius and has an approved issue (issue link required).
  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius Scheduled long running test failed - Run ID: 8649755889 #7490 .

Fixes: #issue_number

@sk593 sk593 requested review from a team as code owners April 11, 2024 22:27
@sk593 sk593 temporarily deployed to functional-tests April 11, 2024 22:29 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Apr 11, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository sk593/radius
Commit ref 26185d1
Unique ID func4509337557
Image tag pr-func4509337557
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func4509337557
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func4509337557
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func4509337557
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func4509337557
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting samples functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting cli functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting shared functional tests...
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ msgrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ cli functional tests succeeded
✅ shared functional tests succeeded

@sk593 sk593 changed the title update login to run always Update az login on LRT to run always Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.83%. Comparing base (6b2b1b2) to head (f2bc522).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7496      +/-   ##
==========================================
- Coverage   63.84%   63.83%   -0.01%     
==========================================
  Files         417      417              
  Lines       23497    23497              
==========================================
- Hits        15001    14999       -2     
- Misses       7227     7228       +1     
- Partials     1269     1270       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sk593 sk593 temporarily deployed to functional-tests April 11, 2024 22:42 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Apr 11, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository sk593/radius
Commit ref f2bc522
Unique ID func1340d7bc81
Image tag pr-func1340d7bc81
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func1340d7bc81
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func1340d7bc81
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func1340d7bc81
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func1340d7bc81
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting cli functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting shared functional tests...
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ cli functional tests succeeded
✅ shared functional tests succeeded

@sk593 sk593 merged commit 5970e72 into radius-project:main Apr 11, 2024
16 checks passed
sk593 added a commit that referenced this pull request Apr 15, 2024
# Description

Minor update to azure cli login in LRT:
#7491

Adding this step to run always in case previous steps fail 

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request fixes a bug in Radius and has an approved issue
(issue link required).
- This pull request adds or changes features of Radius and has an
approved issue (issue link required).
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
#7490 .

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: #issue_number

Signed-off-by: sk593 <[email protected]>
sk593 added a commit that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants