Adding prettier command and running it for the first time #7893
+7,813
−7,651
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,50 +1,50 @@ | ||
| { | ||
| "name": "Radius - Contributor", | ||
| // For details see https://github.com/radius-project/radius/tree/main/docs/contributing/contributing-code/contributing-code-prerequisites | ||
| "image": "mcr.microsoft.com/devcontainers/base:ubuntu", | ||
| "features": { | ||
| //Git and GitHub Setup | ||
| "ghcr.io/devcontainers/features/git:1": {}, | ||
| "ghcr.io/devcontainers/features/github-cli:1": {}, | ||
| //Programming languages | ||
| "ghcr.io/devcontainers/features/go:1": {}, | ||
| "ghcr.io/guiyomh/features/gotestsum:0.1.1": {}, | ||
| "ghcr.io/devcontainers/features/node:1": {}, | ||
| "ghcr.io/devcontainers-contrib/features/typescript:2": {}, | ||
| "ghcr.io/devcontainers/features/python:1": {}, | ||
| //Container and K8s | ||
| "ghcr.io/devcontainers/features/kubectl-helm-minikube:1": { | ||
| "minikube": "none" | ||
| }, | ||
| "ghcr.io/devcontainers/features/docker-in-docker:2": { | ||
| "version": "latest", | ||
| "moby": true | ||
| }, | ||
| //Tools | ||
| "ghcr.io/eitsupi/devcontainer-features/jq-likes:2": {}, | ||
| "ghcr.io/mpriscella/features/kind:1": {}, | ||
| "ghcr.io/dhoeric/features/stern:1": {}, | ||
| //Dapr | ||
| "ghcr.io/dapr/cli/dapr-cli:0": {} | ||
| }, | ||
| "customizations": { | ||
| "vscode": { | ||
| "extensions": [ | ||
| "redhat.vscode-yaml", | ||
| "golang.go", | ||
| "ms-python.python", | ||
| "ms-python.vscode-pylance", | ||
| "ms-azuretools.vscode-bicep", | ||
| "ms-kubernetes-tools.vscode-kubernetes-tools", | ||
| "ms-azuretools.vscode-dapr", | ||
| "ms-vscode.makefile-tools" | ||
| ] | ||
| } | ||
| }, | ||
| // Prerequisite for Code Generation, see https://github.com/radius-project/radius/tree/main/docs/contributing/contributing-code/contributing-code-prerequisites#code-generation | ||
| // Adding workspace as safe directory to avoid permission issues | ||
| "postCreateCommand": "git config --global --add safe.directory /workspaces/radius && cd typespec && npm ci && npm install -g autorest && npm install -g oav && go install sigs.k8s.io/controller-tools/cmd/[email protected] && go install go.uber.org/mock/[email protected]", | ||
| "hostRequirements": { | ||
| "memory": "8gb" | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # .prettierignore | ||
| pkg/validator/testdata/put-environments-invalid-json.json | ||
|
|
||
| hack/bicep-types-radius/generated/* | ||
|
|
||
| bicep-types/* | ||
|
|
||
| swagger/* | ||
ytimocin marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # ------------------------------------------------------------ | ||
| # Copyright 2023 The Radius Authors. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # ------------------------------------------------------------ | ||
|
|
||
| .PHONY: prettier-check prettier-format me prettier | ||
|
|
||
| PRETTIER_VERSION := 3.3.3 | ||
|
|
||
| format-check: | ||
| @echo "$(ARROW) Checking for formatting issues using prettier..." | ||
| @echo "" | ||
| @npx prettier@$(PRETTIER_VERSION) --check "*/**/*.{ts,js,mjs,json}" | ||
|
|
||
| format-write: | ||
| @echo "$(ARROW) Reformatting files using prettier..." | ||
| @echo "" | ||
| @npx prettier@$(PRETTIER_VERSION) --write "*/**/*.{ts,js,mjs,json}" | ||
|
There was a problem hiding this comment. What is the experience like if node is not installed? What about when it's an ancient version of node? |
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,18 @@ | ||
| { | ||
| "name": "Radius CLI", | ||
| "id": "radcli", | ||
| "version": "0.1.0", | ||
| "dependsOn": { | ||
| "ghcr.io/dhoeric/features/oras:1": {} | ||
| }, | ||
| "description": "Installs the Radius CLI along with needed dependencies.", | ||
| "documentationURL": "https://docs.radapp.io/installation/", | ||
| "options": { | ||
| "version": { | ||
| "type": "string", | ||
| "proposals": ["latest", "edge"], | ||
| "default": "latest", | ||
| "description": "Select or enter an Radius CLI version. Use 'latest' for the latest stable version, 'edge' for the latest development version, or a specific version number (e.g. 0.28.0)." | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,18 @@ | ||
| { | ||
| "edge": { | ||
| "image": "mcr.microsoft.com/devcontainers/base:ubuntu", | ||
| "features": { | ||
| "radcli": { | ||
| "version": "edge" | ||
| } | ||
| } | ||
| }, | ||
| "version": { | ||
| "image": "mcr.microsoft.com/devcontainers/base:ubuntu", | ||
| "features": { | ||
| "radcli": { | ||
| "version": "0.27.0" | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 👍