Adding test AKS workflow to v0.32 #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytimocin
force-pushed
the
ytimocin/testAKSWorkflow
branch
2 times, most recently
from
a02b59f
to
60fe6f5
Compare
willtsai
reviewed
Apr 9, 2024
There was a problem hiding this comment.
I don't have enough context to approve this, but based on a similar (already merged) PR#1020, things look largely the same, except for the changes to file playwright/playwright.config.ts. I recommend getting @youngbupark to look at this since he approved the previous PR.
Comment on lines
+49
to
+52
| timeout: 1 * 60 * 1000, | ||
| expect: { | ||
| timeout: 30 * 1000, | ||
| }, |
There was a problem hiding this comment.
would like @youngbupark to take a look here
There was a problem hiding this comment.
I'll review this for Young Bu since he's out right now.
#1020) * Run functional tests every 2 hours and add another workflow that runs the tests on AKS instead of k3d Signed-off-by: ytimocin <[email protected]> * Triggering workflow Signed-off-by: ytimocin <[email protected]> --------- Signed-off-by: ytimocin <[email protected]>
Signed-off-by: ytimocin <[email protected]>
ytimocin
force-pushed
the
ytimocin/testAKSWorkflow
branch
3 times, most recently
from
c1bb198
to
df5cce4
Compare
rynowak
reviewed
Apr 10, 2024
| az login --service-principal \ | ||
| --username ${{ secrets.AZURE_SANDBOX_APP_ID }} \ | ||
| --password ${{ secrets.AZURE_SANDBOX_PASSWORD }} \ | ||
| --tenant ${{ secrets.AZURE_SANDBOX_TENANT_ID }} |
There was a problem hiding this comment.
Can you sync with whomever is updating us to use managed identity here?
There was a problem hiding this comment.
Created this issue: #1058
rynowak
reviewed
Apr 10, 2024
| run: | | ||
| namespace="${{ matrix.env }}-${{ matrix.app }}" | ||
| label="radapp.io/application=${{ matrix.app }}" | ||
| kubectl rollout status deployment -l $label -n $namespace --timeout=90s |
There was a problem hiding this comment.
It would be good to remove this if we can. This is guarantee that Radius is already providing when you deploy the application.
rynowak
reviewed
Apr 10, 2024
| "@types/uuid": "^9.0.3", | ||
| "typescript": "^5.2.2" | ||
| "@playwright/test": "^1.43.0", | ||
| "@types/node": "^20.12.6", |
There was a problem hiding this comment.
Ideally this should match the version of node. We're using 16.x in the pipelines.
rynowak
reviewed
Apr 10, 2024
samples/eshop/infra/networking.bicep
Outdated
| @@ -4,10 +4,13 @@ import radius as rad | |||
| @description('Radius application ID') | |||
| param application string | |||
|
|
|||
| // GATEWAY RESOURCE NAME - Unique string generated from the application and gw | |||
| param gatewayName string = 'gw${uniqueString(application)}' | |||
There was a problem hiding this comment.
Can you double-check why this is needed? We should be generating unique URLs for each gateway that include the application name.
There was a problem hiding this comment.
Reverted this change and, yes, gateway name is gateway + appName @rynowak
rynowak
approved these changes
Apr 10, 2024
|
@ytimocin do you know the cause of the failure? |
ytimocin
force-pushed
the
ytimocin/testAKSWorkflow
branch
from
df5cce4
to
8b85e27
Compare
Signed-off-by: ytimocin <[email protected]>
ytimocin
force-pushed
the
ytimocin/testAKSWorkflow
branch
from
8b85e27
to
12d59dd
Compare
willdavsmith
added a commit
that referenced
this pull request
Apr 22, 2024
* Fix resource type * Fix Dapr mode * Bump express from 4.17.1 to 4.17.3 in /quickstarts/dapr/nodeapp (#108) Bumps [express](https://github.com/expressjs/express) from 4.17.1 to 4.17.3. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.17.1...4.17.3) --- updated-dependencies: - dependency-name: express dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump loader-utils from 2.0.3 to 2.0.4 in /demo/client (#111) Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.3 to 2.0.4. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md) - [Commits](webpack/loader-utils@v2.0.3...v2.0.4) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump minimatch from 3.0.4 to 3.1.2 in /tutorial (#114) Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2. - [Release notes](https://github.com/isaacs/minimatch/releases) - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v3.0.4...v3.1.2) --- updated-dependencies: - dependency-name: minimatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump decode-uri-component from 0.2.0 to 0.2.2 in /tutorial (#113) Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. - [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases) - [Commits](SamVerschueren/decode-uri-component@v0.2.0...v0.2.2) --- updated-dependencies: - dependency-name: decode-uri-component dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump minimatch in /reference-apps/container-app-store/node-service (#112) Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2. - [Release notes](https://github.com/isaacs/minimatch/releases) - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v3.0.4...v3.1.2) --- updated-dependencies: - dependency-name: minimatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump qs and express in /reference-apps/container-app-store/node-service (#110) Bumps [qs](https://github.com/ljharb/qs) to 6.11.0 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together. Updates `qs` from 6.5.2 to 6.11.0 - [Release notes](https://github.com/ljharb/qs/releases) - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.5.2...v6.11.0) Updates `express` from 4.16.4 to 4.18.2 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.16.4...4.18.2) --- updated-dependencies: - dependency-name: qs dependency-type: indirect - dependency-name: express dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump express from 4.17.1 to 4.17.3 in /tutorial (#109) Bumps [express](https://github.com/expressjs/express) from 4.17.1 to 4.17.3. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.17.1...4.17.3) --- updated-dependencies: - dependency-name: express dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Making tutorial match docs version (#116) * Continue on error for container deletion * Update issues.yaml * Change ADO_wit * Update version number * Remove container app store * Add eshop instructions * Revert instructions * Change Bicep installation step * Update issues.yaml * Update issues.yaml * Update issues.yaml * Update test.yaml * Add check for node creation (#240) * Add check for node creation * Correct error message * Add contribution guide * Add Issue templates * Fix link * Fix casing * change mentions of <Project Radius> to just <Radius> (#263) Signed-off-by: Will Tsai <[email protected]> * edge to v0.22 upmerge to pick up changes (#388) Signed-off-by: Will Tsai <[email protected]> * add background info for dapr quickstart (#381) Signed-off-by: Will Tsai <[email protected]> * Switch to sql edge (#398) * Update Dapr UI port (#416) * Change port to 8080 * Update container port * Update configuration * Add error message * Update demo.app.spec.ts (#546) * Add samples release automation (#499) (#554) * Bump word-wrap from 1.2.3 to 1.2.5 in /demo/client (#431) Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.5. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.5) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aaron Crawfis <[email protected]> * Bump golang.org/x/net in /reference-apps/container-app-store/go-service (#593) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.0.0-20210929193557-e81a3d93ecf6 to 0.17.0. - [Commits](https://github.com/golang/net/commits/v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add issue labels (#858) Signed-off-by: Aaron Crawfis <[email protected]> * Remove customer label Signed-off-by: Aaron Crawfis <[email protected]> * Fix failing CI in 0.27 branch (#881) * Fix Dapr sample in CI (#817) * Adding debug for pod list Signed-off-by: willdavsmith <[email protected]> * Adding debug for pod list Signed-off-by: willdavsmith <[email protected]> * Adding debug for pod list Signed-off-by: willdavsmith <[email protected]> * Adding debug for pod list Signed-off-by: willdavsmith <[email protected]> * Adding debug for pod list Signed-off-by: willdavsmith <[email protected]> * make sure it's not flaky Signed-off-by: willdavsmith <[email protected]> * remove debug Signed-off-by: willdavsmith <[email protected]> --------- Signed-off-by: willdavsmith <[email protected]> (cherry picked from commit 5f6bd44) * Force delete Radius application, EKS Cluster, and AWS resources on failed workflow run (#843) Signed-off-by: willdavsmith <[email protected]> (cherry picked from commit 4855d47) * Bump @adobe/css-tools from 4.3.1 to 4.3.2 in /samples/demo/client (#886) Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.3.1 to 4.3.2. - [Changelog](https://github.com/adobe/css-tools/blob/main/History.md) - [Commits](https://github.com/adobe/css-tools/commits) --- updated-dependencies: - dependency-name: "@adobe/css-tools" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix Dapr microservices sample (#654) * Adding application name for dapr app * Adding application name for dapr app * Update samples/dapr/.rad/rad.yaml Signed-off-by: Will <[email protected]> --------- Signed-off-by: Will <[email protected]> Co-authored-by: Will <[email protected]> * Fix Dapr microservices sample (#654) (#890) * Adding application name for dapr app * Adding application name for dapr app * Update samples/dapr/.rad/rad.yaml --------- Signed-off-by: Will <[email protected]> Signed-off-by: Will Tsai <[email protected]> Co-authored-by: MD Ashique <[email protected]> * Upmerge v0.27 to v0.28 (#903) * Add edge rad CLI pull to samples tests (#737) * Add install-radius script Signed-off-by: willdavsmith <[email protected]> * chmod Signed-off-by: willdavsmith <[email protected]> * test Signed-off-by: willdavsmith <[email protected]> * test Signed-off-by: willdavsmith <[email protected]> * test Signed-off-by: willdavsmith <[email protected]> * test Signed-off-by: willdavsmith <[email protected]> * test Signed-off-by: willdavsmith <[email protected]> * test Signed-off-by: willdavsmith <[email protected]> * test Signed-off-by: willdavsmith <[email protected]> * PR Signed-off-by: willdavsmith <[email protected]> * PR Signed-off-by: willdavsmith <[email protected]> * PR Signed-off-by: willdavsmith <[email protected]> * PR Signed-off-by: willdavsmith <[email protected]> * PR Signed-off-by: willdavsmith <[email protected]> * PR Signed-off-by: willdavsmith <[email protected]> --------- Signed-off-by: willdavsmith <[email protected]> Signed-off-by: Will Tsai <[email protected]> * dapr tutorial port and routes fixes Signed-off-by: Will Tsai <[email protected]> * Revert "Update container build to only push on merges (#726)" This reverts commit 54b3d4e. Signed-off-by: Will Tsai <[email protected]> * Revert "Revert "Update container build to only push on merges (#726)"" This reverts commit 7cfd4ad. Signed-off-by: Will Tsai <[email protected]> * Revert "dapr tutorial port and routes fixes" This reverts commit 7f6f525. Signed-off-by: Will Tsai <[email protected]> * dapr tutorial port and routes fixes (#748) Signed-off-by: Will Tsai <[email protected]> * Update condition Signed-off-by: Aaron Crawfis <[email protected]> Signed-off-by: Will Tsai <[email protected]> * Update rad-bicep pull Signed-off-by: Aaron Crawfis <[email protected]> Signed-off-by: Will Tsai <[email protected]> * Update eShop to use Recipes (#590) * Replace eShop with eShop on recipes * PR * Fix * Test * PR * oops * Updates * PR * PR * PR * PR comments * PR comments * fixing * again * fix * rewind * PR * PR * Simplify env registration Signed-off-by: Aaron Crawfis <[email protected]> * Make registry a parameter Signed-off-by: Aaron Crawfis <[email protected]> * Update test Signed-off-by: Aaron Crawfis <[email protected]> * Update namespaces Signed-off-by: Aaron Crawfis <[email protected]> * Fix tag Signed-off-by: Aaron Crawfis <[email protected]> * Update env names Signed-off-by: Aaron Crawfis <[email protected]> * Fix namespaces Signed-off-by: Aaron Crawfis <[email protected]> * Fix recipe Signed-off-by: Aaron Crawfis <[email protected]> --------- Signed-off-by: Aaron Crawfis <[email protected]> Co-authored-by: Aaron Crawfis <[email protected]> Signed-off-by: Will Tsai <[email protected]> * Fix Dapr sample in CI (#817) * Adding debug for pod list Signed-off-by: willdavsmith <[email protected]> * Adding debug for pod list Signed-off-by: willdavsmith <[email protected]> * Adding debug for pod list Signed-off-by: willdavsmith <[email protected]> * Adding debug for pod list Signed-off-by: willdavsmith <[email protected]> * Adding debug for pod list Signed-off-by: willdavsmith <[email protected]> * make sure it's not flaky Signed-off-by: willdavsmith <[email protected]> * remove debug Signed-off-by: willdavsmith <[email protected]> --------- Signed-off-by: willdavsmith <[email protected]> Signed-off-by: Will Tsai <[email protected]> * Force delete Radius application, EKS Cluster, and AWS resources on failed workflow run (#843) Signed-off-by: willdavsmith <[email protected]> Signed-off-by: Will Tsai <[email protected]> * Remove customer label Signed-off-by: Aaron Crawfis <[email protected]> Signed-off-by: Will Tsai <[email protected]> * Add issue labels (#858) Signed-off-by: Aaron Crawfis <[email protected]> Signed-off-by: Will Tsai <[email protected]> * Bump @adobe/css-tools from 4.3.1 to 4.3.2 in /samples/demo/client (#886) Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.3.1 to 4.3.2. - [Changelog](https://github.com/adobe/css-tools/blob/main/History.md) - [Commits](https://github.com/adobe/css-tools/commits) --- updated-dependencies: - dependency-name: "@adobe/css-tools" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Will Tsai <[email protected]> * Fix Dapr microservices sample (#654) (#890) * Adding application name for dapr app * Adding application name for dapr app * Update samples/dapr/.rad/rad.yaml --------- Signed-off-by: Will <[email protected]> Signed-off-by: Will Tsai <[email protected]> Co-authored-by: MD Ashique <[email protected]> Signed-off-by: Will Tsai <[email protected]> --------- Signed-off-by: willdavsmith <[email protected]> Signed-off-by: Will Tsai <[email protected]> Signed-off-by: Aaron Crawfis <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Will <[email protected]> Co-authored-by: Will Smith <[email protected]> Co-authored-by: Aaron Crawfis <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: MD Ashique <[email protected]> * Update changes in test.yaml workflow into v0.28 (#904) * Add test-failure label to issues created for samples failures (#899) Signed-off-by: karishma-chawla <[email protected]> Co-authored-by: karishma-chawla <[email protected]> * updating condition to specify scheduled run --------- Signed-off-by: karishma-chawla <[email protected]> Signed-off-by: Lakshmi Javadekar <[email protected]> Co-authored-by: Karishma Chawla <[email protected]> Co-authored-by: karishma-chawla <[email protected]> * Fixing AWS RDS Purge workflow (#970) * Add aws login (#974) Signed-off-by: willdavsmith <[email protected]> * Add GH action to close stale PRs (#977) * Add GH action to close stale PRs Signed-off-by: karishma-chawla <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Aaron Crawfis <[email protected]> Signed-off-by: Karishma Chawla <[email protected]> * Update radius repo link Signed-off-by: Karishma Chawla <[email protected]> --------- Signed-off-by: karishma-chawla <[email protected]> Signed-off-by: Karishma Chawla <[email protected]> Co-authored-by: karishma-chawla <[email protected]> Co-authored-by: Aaron Crawfis <[email protected]> * Adding a secton that waits until the app is ready (#980) Signed-off-by: ytimocin <[email protected]> * Update images for guestbook sample app (#986) * update images for guestbook sample app Signed-off-by: Will Tsai <[email protected]> * update images for guestbook sample app Signed-off-by: Will Tsai <[email protected]> * move images to /samples path Signed-off-by: Will Tsai <[email protected]> --------- Signed-off-by: Will Tsai <[email protected]> * Bump webpack-dev-middleware from 5.3.3 to 5.3.4 in /samples/demo/client (#1023) Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.3 to 5.3.4. - [Release notes](https://github.com/webpack/webpack-dev-middleware/releases) - [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md) - [Commits](webpack/webpack-dev-middleware@v5.3.3...v5.3.4) --- updated-dependencies: - dependency-name: webpack-dev-middleware dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump follow-redirects from 1.15.4 to 1.15.6 in /samples/demo/client (#1014) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump ip from 2.0.0 to 2.0.1 in /samples/demo (#984) Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Will <[email protected]> * Bump follow-redirects from 1.15.5 to 1.15.6 in /playwright (#1015) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.5 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.5...v1.15.6) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Will <[email protected]> * Bump express from 4.18.2 to 4.19.2 in /samples/demo/client (#1027) Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.18.2...4.19.2) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Will <[email protected]> * Bump express from 4.18.2 to 4.19.2 in /samples/demo (#1028) Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.18.2...4.19.2) --- updated-dependencies: - dependency-name: express dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Will <[email protected]> * Bump express from 4.18.2 to 4.19.2 in /samples/dapr/nodeapp (#1026) Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.18.2...4.19.2) --- updated-dependencies: - dependency-name: express dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Will <[email protected]> * Make env configurable (#1046) Signed-off-by: Reshma Abdul Rahim <[email protected]> * Adding test AKS workflow to v0.32 (#1052) * Run functional tests every 2 hours and add another workflow that runs… (#1020) * Run functional tests every 2 hours and add another workflow that runs the tests on AKS instead of k3d Signed-off-by: ytimocin <[email protected]> * Triggering workflow Signed-off-by: ytimocin <[email protected]> --------- Signed-off-by: ytimocin <[email protected]> * Removing the run of the AKS workflow on PRs (#1051) Signed-off-by: ytimocin <[email protected]> * Update the timeout (30s) for Playwright Signed-off-by: ytimocin <[email protected]> --------- Signed-off-by: ytimocin <[email protected]> * Removing code * Removing code * Removing code * Use retry and update eshop playwright tests to wait for the catalog to appear (#1213) Signed-off-by: ytimocin <[email protected]> * Fixing eshop page Signed-off-by: willdavsmith <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Will Tsai <[email protected]> Signed-off-by: Aaron Crawfis <[email protected]> Signed-off-by: Will <[email protected]> Signed-off-by: willdavsmith <[email protected]> Signed-off-by: karishma-chawla <[email protected]> Signed-off-by: Lakshmi Javadekar <[email protected]> Signed-off-by: Karishma Chawla <[email protected]> Signed-off-by: ytimocin <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Aaron Crawfis <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Justin Kotalik <[email protected]> Co-authored-by: Will <[email protected]> Co-authored-by: MD Ashique <[email protected]> Co-authored-by: Lakshmi Javadekar <[email protected]> Co-authored-by: Karishma Chawla <[email protected]> Co-authored-by: karishma-chawla <[email protected]> Co-authored-by: Yetkin Timocin <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]>
willdavsmith
added a commit
that referenced
this pull request
Apr 25, 2024
* Make env configurable (#1046) Signed-off-by: Reshma Abdul Rahim <[email protected]> * Adding test AKS workflow to v0.32 (#1052) * Run functional tests every 2 hours and add another workflow that runs… (#1020) * Run functional tests every 2 hours and add another workflow that runs the tests on AKS instead of k3d Signed-off-by: ytimocin <[email protected]> * Triggering workflow Signed-off-by: ytimocin <[email protected]> --------- Signed-off-by: ytimocin <[email protected]> * Removing the run of the AKS workflow on PRs (#1051) Signed-off-by: ytimocin <[email protected]> * Update the timeout (30s) for Playwright Signed-off-by: ytimocin <[email protected]> --------- Signed-off-by: ytimocin <[email protected]> * Use retry and update eshop playwright tests to wait for the catalog to appear (#1213) Signed-off-by: ytimocin <[email protected]> --------- Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: ytimocin <[email protected]> Signed-off-by: willdavsmith <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Yetkin Timocin <[email protected]>
willtsai
added a commit
that referenced
this pull request
Apr 25, 2024
* Make env configurable (#1046) Signed-off-by: Reshma Abdul Rahim <[email protected]> * Adding test AKS workflow to v0.32 (#1052) * Run functional tests every 2 hours and add another workflow that runs… (#1020) * Run functional tests every 2 hours and add another workflow that runs the tests on AKS instead of k3d Signed-off-by: ytimocin <[email protected]> * Triggering workflow Signed-off-by: ytimocin <[email protected]> --------- Signed-off-by: ytimocin <[email protected]> * Removing the run of the AKS workflow on PRs (#1051) Signed-off-by: ytimocin <[email protected]> * Update the timeout (30s) for Playwright Signed-off-by: ytimocin <[email protected]> --------- Signed-off-by: ytimocin <[email protected]> * Use retry and update eshop playwright tests to wait for the catalog to appear (#1213) Signed-off-by: ytimocin <[email protected]> * update gh to ado sync workflow to use service principals Signed-off-by: Will Tsai <[email protected]> --------- Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: ytimocin <[email protected]> Signed-off-by: Will Tsai <[email protected]> Signed-off-by: Will <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Yetkin Timocin <[email protected]>
sk593
pushed a commit
that referenced
this pull request
May 23, 2024
* Make env configurable (#1046) Signed-off-by: Reshma Abdul Rahim <[email protected]> * Adding test AKS workflow to v0.32 (#1052) * Run functional tests every 2 hours and add another workflow that runs… (#1020) * Run functional tests every 2 hours and add another workflow that runs the tests on AKS instead of k3d Signed-off-by: ytimocin <[email protected]> * Triggering workflow Signed-off-by: ytimocin <[email protected]> --------- Signed-off-by: ytimocin <[email protected]> * Removing the run of the AKS workflow on PRs (#1051) Signed-off-by: ytimocin <[email protected]> * Update the timeout (30s) for Playwright Signed-off-by: ytimocin <[email protected]> --------- Signed-off-by: ytimocin <[email protected]> * Use retry and update eshop playwright tests to wait for the catalog to appear (#1213) Signed-off-by: ytimocin <[email protected]> * update gh to ado sync workflow to use service principals Signed-off-by: Will Tsai <[email protected]> --------- Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: ytimocin <[email protected]> Signed-off-by: Will Tsai <[email protected]> Signed-off-by: Will <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Yetkin Timocin <[email protected]> Signed-off-by: sk593 <[email protected]>
sk593
pushed a commit
that referenced
this pull request
May 23, 2024
* Make env configurable (#1046) Signed-off-by: Reshma Abdul Rahim <[email protected]> * Adding test AKS workflow to v0.32 (#1052) * Run functional tests every 2 hours and add another workflow that runs… (#1020) * Run functional tests every 2 hours and add another workflow that runs the tests on AKS instead of k3d Signed-off-by: ytimocin <[email protected]> * Triggering workflow Signed-off-by: ytimocin <[email protected]> --------- Signed-off-by: ytimocin <[email protected]> * Removing the run of the AKS workflow on PRs (#1051) Signed-off-by: ytimocin <[email protected]> * Update the timeout (30s) for Playwright Signed-off-by: ytimocin <[email protected]> --------- Signed-off-by: ytimocin <[email protected]> * Use retry and update eshop playwright tests to wait for the catalog to appear (#1213) Signed-off-by: ytimocin <[email protected]> * update gh to ado sync workflow to use service principals Signed-off-by: Will Tsai <[email protected]> --------- Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: ytimocin <[email protected]> Signed-off-by: Will Tsai <[email protected]> Signed-off-by: Will <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Yetkin Timocin <[email protected]> Signed-off-by: sk593 <[email protected]>
sk593
added a commit
that referenced
this pull request
May 23, 2024
* update gh to ado sync workflow to use service principals (#1363) * Make env configurable (#1046) Signed-off-by: Reshma Abdul Rahim <[email protected]> * Adding test AKS workflow to v0.32 (#1052) * Run functional tests every 2 hours and add another workflow that runs… (#1020) * Run functional tests every 2 hours and add another workflow that runs the tests on AKS instead of k3d Signed-off-by: ytimocin <[email protected]> * Triggering workflow Signed-off-by: ytimocin <[email protected]> --------- Signed-off-by: ytimocin <[email protected]> * Removing the run of the AKS workflow on PRs (#1051) Signed-off-by: ytimocin <[email protected]> * Update the timeout (30s) for Playwright Signed-off-by: ytimocin <[email protected]> --------- Signed-off-by: ytimocin <[email protected]> * Use retry and update eshop playwright tests to wait for the catalog to appear (#1213) Signed-off-by: ytimocin <[email protected]> * update gh to ado sync workflow to use service principals Signed-off-by: Will Tsai <[email protected]> --------- Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: ytimocin <[email protected]> Signed-off-by: Will Tsai <[email protected]> Signed-off-by: Will <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Yetkin Timocin <[email protected]> Signed-off-by: sk593 <[email protected]> * Workflow and playwright test updates (#1360) Signed-off-by: ytimocin <[email protected]> Signed-off-by: sk593 <[email protected]> * Changing the place of page.reload in the tests (#1492) Signed-off-by: ytimocin <[email protected]> Signed-off-by: sk593 <[email protected]> * Adding a job that will purge AWS EKS clusters every 6 hours (#1462) Signed-off-by: ytimocin <[email protected]> Signed-off-by: sk593 <[email protected]> * Update all deps of all apps (#1536) Signed-off-by: ytimocin <[email protected]> Signed-off-by: sk593 <[email protected]> * Updating the runner of purge azure test resources workflow (#1537) Signed-off-by: ytimocin <[email protected]> Signed-off-by: sk593 <[email protected]> * Update purget test resources to fix the workflow failures (#1552) Signed-off-by: ytimocin <[email protected]> Signed-off-by: sk593 <[email protected]> * Fixing the eShop catalog load issue for the UI tests (#1548) Signed-off-by: ytimocin <[email protected]> Signed-off-by: sk593 <[email protected]> --------- Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: ytimocin <[email protected]> Signed-off-by: Will Tsai <[email protected]> Signed-off-by: Will <[email protected]> Signed-off-by: sk593 <[email protected]> Co-authored-by: Will <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Yetkin Timocin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding test AKS workflow to v0.32 so that it can run as scheduled.
I merged changes to edge but the action doesn't run as scheduled. Please see this list: https://github.com/radius-project/samples/actions/workflows/test-aks.yaml. The last run was more than 2 hours ago and the scheduled job is supposed to run every 2 hours.