[Tooltip] Content accessible via pointer #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-hook
force-pushed
the
620-tooltip-wcag
branch
8 times, most recently
from
5b6c67c
to
4ec4ba5
Compare
andy-hook
commented
Jun 23, 2022
andy-hook
force-pushed
the
620-tooltip-wcag
branch
from
4ec4ba5
to
a483b01
Compare
benoitgrelard
approved these changes
Jul 7, 2022
| const isPointerDownRef = React.useRef(false); | ||
| const hasTriggerActivated = React.useRef(false); |
There was a problem hiding this comment.
What does this one mean?
When I read the name I thought it was about the trigger activation (click, keydown space/enter) but looking at where the ref is updated it seems to mean something else.
There was a problem hiding this comment.
We needed to use pointerMove after all for the polygon bleed change. Because of this we only want to trigger an open on the very first pointerMove event, this flag is to describe that the tooltip "has opened" already so don't do it again until we leave and come back.
Perhaps something like hasPointerMoveOpened?
There was a problem hiding this comment.
Yeah that makes more sense.
benoitgrelard
approved these changes
Jul 7, 2022
luisorbaiceta
pushed a commit
to luisorbaiceta/primitives
that referenced
this pull request
Jul 21, 2022
* Remain open when pointer over content * Feedback * Additional simplification * Improve grace area accuracy * Naming, remove debugging area
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #620
Of the options available we decided on:
CleanShot.2022-06-24.at.12.34.23.mp4