Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: index referring to scope?.[scopeName] being undefined #3047

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

loonskai
Copy link
Contributor

@loonskai loonskai commented Aug 3, 2024

Description

Adding an additional optional chaining operator for scope?.[scopeName]?.[index]. We started seeing scope?.[scopeName] as undefined after switching to esbuild under specific conditions.
Not sure whether such situation happens because a scope is not provided or there is incorrect scope composition. Adding an extra layer of safety ensures that both scope?.[scopeName] and scope?.[scopeName]?.[index] are properly checked.

@chaance chaance merged commit 32d176d into radix-ui:main Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants