Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intergration: add support for record error msg when execute error cas… #612

Conversation

hustjieke
Copy link
Contributor

…e #611

[summary]
Add support for recording error case in result test file, e.g.:

create table integrate_test.t(a int key, b int) ENGINE=InnoDB DEFAULT CHARSET=utf8;
select c from integrate_test.t;
ERROR 1054 (42S22): Unknown column 'c' in 'field list'

[test case]
N/A
[patch codecov]
N/A

…radondb#611

[summary]
Add support for recording error case in result test file, e.g.:

create table integrate_test.t(a int key, b int) ENGINE=InnoDB DEFAULT CHARSET=utf8;
select c from integrate_test.t;
ERROR 1054 (42S22): Unknown column 'c' in 'field list'

[test case]
N/A
[patch codecov]
N/A
@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #612 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #612   +/-   ##
======================================
  Coverage      89%     89%           
======================================
  Files         128     128           
  Lines       10206   10206           
======================================
  Hits         9155    9155           
  Misses        710     710           
  Partials      341     341           
Impacted Files Coverage Δ
src/executor/engine/merge_join.go 96% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28709ba...264c828. Read the comment docs.

@hustjieke hustjieke marked this pull request as ready for review April 14, 2020 15:18
@BohuTANG BohuTANG merged commit b39f2b9 into radondb:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants