sqlparser: column option and table option #615 #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hustjieke
force-pushed
the
feature_add_options_for_create_table_#615
branch
from
f003872
to
9d10791
Compare
[summary] reference: https://dev.mysql.com/doc/refman/5.7/en/create-table.html 1. complete more columnn options, add `STORAGE DEFAULT` which is not descriped on official 5.7 document, but actually mysql support it. see: https://github.com/mysql/mysql-server/blob/5.7/sql/sql_yacc.yy#L6953 and extra option suppored by mysql: `ON UPDATE ...` see: https://github.com/mysql/mysql-server/blob/5.7/sql/sql_yacc.yy#L6888 ``` column_definition: data_type [NOT NULL | NULL] [DEFAULT default_value] [AUTO_INCREMENT] [UNIQUE [KEY]] [[PRIMARY] KEY] [COMMENT 'string'] [COLLATE collation_name] [COLUMN_FORMAT {FIXED | DYNAMIC | DEFAULT}] [STORAGE {DISK | MEMORY}] [ON UPDATE NOW_SYM] | data_type [COLLATE collation_name] [VIRTUAL | STORED] [NOT NULL | NULL] [UNIQUE [KEY]] [[PRIMARY] KEY] [COMMENT 'string'] ``` Currently we do not support column option ` [reference_definition]`, ` [GENERATED ALWAYS] AS (expr)` also : some `DEFAULT now_or_signed_literal` and `SERIAL_SYM DEFAULT VALUE_SYM` options not in 5.7 document, but acctually mysql support them. see: https://github.com/mysql/mysql-server/blob/5.7/sql/sql_yacc.yy#L6897 https://github.com/mysql/mysql-server/blob/5.7/sql/sql_yacc.yy#L6887 2. complete more table options. ``` table_option: AUTO_INCREMENT [=] value | AVG_ROW_LENGTH [=] value | [DEFAULT] CHARACTER SET [=] charset_name | CHECKSUM [=] {0 | 1} | [DEFAULT] COLLATE [=] collation_name | COMMENT [=] 'string' | COMPRESSION [=] {'ZLIB' | 'LZ4' | 'NONE'} | CONNECTION [=] 'connect_string' | {DATA | INDEX} DIRECTORY [=] 'absolute path to directory' | DELAY_KEY_WRITE [=] {0 | 1} | ENCRYPTION [=] {'Y' | 'N'} | ENGINE [=] engine_name | INSERT_METHOD [=] { NO | FIRST | LAST } | KEY_BLOCK_SIZE [=] value | MAX_ROWS [=] value | MIN_ROWS [=] value | PACK_KEYS [=] {0 | 1 | DEFAULT} | PASSWORD [=] 'string' | ROW_FORMAT [=] {DEFAULT | DYNAMIC | FIXED | COMPRESSED | REDUNDANT | COMPACT | TOKUDB...} | STATS_AUTO_RECALC [=] {DEFAULT | 0 | 1} | STATS_PERSISTENT [=] {DEFAULT | 0 | 1} | STATS_SAMPLE_PAGES [=] value | TABLESPACE tablespace_name [STORAGE {DISK | MEMORY}] ``` Currently we do not support table options: `UNION [=] (tbl_name[,tbl_name]...)` [test case] sqlparser/parse_test.go sqlparser/ddl_test.go proxy/ddl_test.go [patch codecov] N/A
hustjieke
force-pushed
the
feature_add_options_for_create_table_#615
branch
from
9d10791
to
eef2752
Compare
Codecov Report
@@ Coverage Diff @@
## master #628 +/- ##
======================================
- Coverage 89% 89% -1%
======================================
Files 128 128
Lines 10234 10234
======================================
- Hits 9183 9179 -4
- Misses 710 712 +2
- Partials 341 343 +2
Continue to review full report at Codecov.
|
|
@andyli029 |
|
ACK |
andyli029
reviewed
May 7, 2020
| { | ||
| $$ = string($2) | ||
| } | ||
| | COLUMN_FORMAT DYNAMIC |
| { | ||
| $$ = string($2) | ||
| } | ||
| | COLUMN_FORMAT DEFAULT |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[summary]
reference: https://dev.mysql.com/doc/refman/5.7/en/create-table.html
STORAGE DEFAULTwhich is not descriped on official 5.7 document, but actually mysql support it.see: https://github.com/mysql/mysql-server/blob/5.7/sql/sql_yacc.yy#L6953
and extra option suppored by mysql:
ON UPDATE ...see: https://github.com/mysql/mysql-server/blob/5.7/sql/sql_yacc.yy#L6888
Currently we do not support column option
[reference_definition],[GENERATED ALWAYS] AS (expr)also : some
DEFAULT now_or_signed_literalandSERIAL_SYM DEFAULT VALUE_SYMoptions not in 5.7 document, but acctually mysql support them.see:
https://github.com/mysql/mysql-server/blob/5.7/sql/sql_yacc.yy#L6897
https://github.com/mysql/mysql-server/blob/5.7/sql/sql_yacc.yy#L6887
Currently we do not support table options:
UNION [=] (tbl_name[,tbl_name]...)[test case]
sqlparser/parse_test.go
sqlparser/ddl_test.go
proxy/ddl_test.go
[patch codecov]
N/A