Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: divide radon_sql_support.md into different files #647 #657

Merged
merged 2 commits into from
Jul 16, 2020
Merged

docs: divide radon_sql_support.md into different files #647 #657

merged 2 commits into from
Jul 16, 2020

Conversation

hustjieke
Copy link
Contributor

[summary]
divide radon_sql_support.md into different files

[test case]
N/A
[patch codecov]
N/A

@hustjieke hustjieke force-pushed the feature_divide_radon_sql_doc_to_diff_docs_#647 branch from 6a09b4e to 54ae846 Compare July 15, 2020 17:04
@codecov
Copy link

codecov bot commented Jul 15, 2020 •
edited
Loading

Codecov Report

Merging #657 into master will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #657   +/-   ##
======================================
- Coverage      89%     89%   -1%     
======================================
  Files         129     129           
  Lines       10390   10390           
======================================
- Hits         9334    9330    -4     
- Misses        709     712    +3     
- Partials      347     348    +1
Impacted Files Coverage Δ
src/backend/connection.go 88% <0%> (-2%) ⬇️
src/executor/engine/merge_join.go 95% <0%> (-2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7a1c51...0252391. Read the comment docs.

@hustjieke hustjieke force-pushed the feature_divide_radon_sql_doc_to_diff_docs_#647 branch 2 times, most recently from 6968cf8 to 04a33fb Compare July 16, 2020 02:20
@hustjieke hustjieke marked this pull request as ready for review July 16, 2020 02:21
@BohuTANG
Copy link
Contributor

Good.
It would be better if the md file name was lowercase.

@hustjieke
docs: divide radon_sql_support.md into different files radondb#647
edc9a9b 
[summary]
divide radon_sql_support.md into different files

[test case]
N/A
[patch codecov]
N/A
@hustjieke hustjieke force-pushed the feature_divide_radon_sql_doc_to_diff_docs_#647 branch from 04a33fb to edc9a9b Compare July 16, 2020 03:29
@hustjieke
Copy link
Contributor Author

push update: change the md file name to lowercase.

zhyass
zhyass reviewed Jul 16, 2020
View reviewed changes
Copy link
Contributor

@zhyass zhyass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BohuTANG
Copy link
Contributor

push update: change the md file name to lowercase.

docs/sql_statements/Data_Definition_Statements.md still upper case.
Don't use force-update if it's a normal commit, the reviewer won't see the changes under force-update.

@hustjieke
docs: rename upper case files to lower case files radondb#647
0252391 
[summary]
rename upper case files to lower case files

[test case]
N/A
[patch codecov]
N/A
@BohuTANG BohuTANG merged commit b4b5355 into radondb:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhyass zhyass zhyass left review comments

@andyli029 andyli029 Awaiting requested review from andyli029

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hustjieke @BohuTANG @zhyass