Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support show index syntax #679 #680

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Conversation

zhyass
Copy link
Contributor

@zhyass zhyass commented Sep 1, 2020

[summary]
Support show index syntax.

SHOW {INDEX | INDEXES | KEYS}
{FROM | IN} tbl_name
[{FROM | IN} db_name]
[WHERE expr]

[test case]
src/proxy/show_test.go
src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/show_test.go

[patch codecov]
src/proxy/query.go 88.7%
src/proxy/show.go 90.1%
src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast.go 96.8%

[summary]
Support show index syntax.

SHOW {INDEX | INDEXES | KEYS}
    {FROM | IN} tbl_name
    [{FROM | IN} db_name]
    [WHERE expr]

[test case]
src/proxy/show_test.go
src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/show_test.go

[patch codecov]
src/proxy/query.go 88.7%
src/proxy/show.go 90.1%
src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast.go 96.8%
@zhyass zhyass requested a review from BohuTANG September 1, 2020 11:25
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #680 into master will decrease coverage by 0%.
The diff coverage is 93%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #680   +/-   ##
======================================
- Coverage      90%     89%   -1%     
======================================
  Files         130     130           
  Lines       10501   10530   +29     
======================================
+ Hits         9453    9472   +19     
- Misses        704     711    +7     
- Partials      344     347    +3     
Impacted Files Coverage Δ
src/proxy/show.go 83% <92%> (+<1%) ⬆️
src/proxy/query.go 86% <100%> (+<1%) ⬆️
src/backend/connection.go 88% <0%> (-5%) ⬇️
src/backend/pool.go 89% <0%> (-4%) ⬇️
src/executor/engine/merge_join.go 96% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22461ca...a36087d. Read the comment docs.

@BohuTANG BohuTANG merged commit 3d5ca8e into radondb:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants