Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark private threads category as read improvements #1806

Closed
wants to merge 3 commits into from
Closed

Mark private threads category as read improvements #1806

wants to merge 3 commits into from

Conversation

rafalp
Copy link
Owner

@rafalp rafalp commented Sep 4, 2024

Updates mark_category_read calls for private threads category to don't call mark_category_read because it doesn't make sense for those.

Fixes #1803

@rafalp rafalp added area: backend This issue involves Python, Django or dependency (eg. database) feature: read tracker Tracks read and unread threads and posts feature: threads list Lists of threads feature: thread page Thread and private thread pages labels Sep 4, 2024
@rafalp rafalp added this to the Next feature release milestone Sep 4, 2024
@rafalp rafalp self-assigned this Sep 4, 2024
@rafalp rafalp closed this Sep 5, 2024
@rafalp rafalp deleted the fix-1803-improve-mark-private-threads-as-read branch September 5, 2024 16:29
@rafalp
Copy link
Owner Author

rafalp commented Sep 5, 2024

This approach will break "mark as read" feature for private threads. I think I'll rather show users new private threads with invalid read states

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rafalp rafalp

Labels
area: backend This issue involves Python, Django or dependency (eg. database) feature: read tracker Tracks read and unread threads and posts feature: thread page Thread and private thread pages feature: threads list Lists of threads
Projects
None yet
Milestone
Next feature release
Development

Successfully merging this pull request may close these issues.

Don't mark category as read in private threads mark as read actions
1 participant
@rafalp