Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataclasses #3969
Dataclasses #3969
Changes from all commits
46a1416
d2cd3d8
c8ca385
1912b07
22b6100
091d488
8e6765a
4595dbc
b510beb
4982f16
706c8cd
c60daee
22a312a
867ad0a
5813d3c
530d211
5be3c4d
e136302
371e2e7
16d3f0e
64d39d1
b3090cd
70a48ec
f87bd63
7447956
cba49d4
eab8953
5a1ee42
da43e32
ce3d4e6
a921396
e4e8536
f2c69be
7b0f9ce
2feebbb
57bf69e
0ade4a5
922340f
58e28bc
dcce4dc
02b7ef1
c6ea7d4
851aeea
fed6c6e
3dfc5dd
74073c8
65556c4
0fb7605
029f63d
af92ed5
8aa5b7f
b54790f
90e0d26
aa7d975
2ed77ed
a02e473
19f799f
f6ef20a
4b372c7
0ac1488
a45ff85
b0fa076
91e8760
70c8c7a
8cbb340
cb7ae9c
359f7cd
0acbc08
f159a21
3d94101
7b339b6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref: pylint-dev/pylint#2698
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, in our case this happens when
field(repr=False)
is used and the field that is another dataclass. Shouldn't we just remove thefield(repr=False)
and have the lint working?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing
field(repr=False)
in the case where we only disable repr for these fields is possible. However, there will be many different places where we need to override the field with something else.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but this would fix roughly 32 instances that are just
repr=True
. Counted with:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked this point out. Most of the
disable=E1101
were added becausepartner_state
andour_state
are defined asfield(repr=False)
. However, i would argue that setting them to be included inrepr
would be a bit too much because of the amount of data that will end up being logged.Do you think we should accept this and remove
field
assignment to those attributes?