-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pip-tools #5987
Update pip-tools #5987
Conversation
It's annoying for linux users to manually make sure that it stays included every time they compile the deps. It's only required for MacOS systems and we don't want to have it in the diff every time it is compiled on a different OS.
requirements/requirements-dev.txt
Outdated
@@ -4,182 +4,182 @@ | |||
# | |||
# './deps compile' (for details see README) | |||
# | |||
alabaster==0.7.12 | |||
aniso8601==7.0.0 | |||
alabaster==0.7.12 # via -r /home/karl/raiden/requirements/requirements-docs.txt, sphinx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we somehow avoid having anyone's username in there? Otherwise the diff will be this big for every change from different people.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh, that's wrong of course! Why did it put the full path in there? I'll see if I can change that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like others have the same problem. Why does it work for dependabot, see #5986 and jazzband/pip-tools#1067?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume the reason is that our wrapper script (that handles the dependency resolution between the files) passes absolute paths.
I'll see if that is easily fixable.
The diff is so big due to jazzband/pip-tools#1058.
To prevent absolute paths in our pip-compile output we now pass paths relative to the working directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
The diff is so big due to jazzband/pip-tools#1058 and I wanted to avoid having that diff inside another PR. I also explicitly excluded
macholib
as a ci dependency to avoid differences between MacOS and linux machines.