Fix use of super in define_method
#663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveklabnik
added a commit
that referenced
this pull request
Sep 23, 2014
Fix use of `super` in `define_method`
|
It's all good! It happens. Thank you! |
tricknotes
added a commit
to tricknotes/active_model_serializers
that referenced
this pull request
Oct 9, 2014
This patch is the same fixes as rails-api#655 and rails-api#663 for 0-9-stable branch.
tricknotes
added a commit
to tricknotes/active_model_serializers
that referenced
this pull request
Oct 9, 2014
This patch is the same fixes as rails-api#655 and rails-api#663 .
This was referenced Oct 9, 2014
Merged
plehoux
pushed a commit
to plehoux/active_model_serializers
that referenced
this pull request
Jan 9, 2015
This patch is the same fixes as rails-api#655 and rails-api#663 for 0-9-stable branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to explicitly specify arguments when using
superindefine_method.I messed this up in #655.