Remove and warn depracated config tld_length
#72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tld_length was removed in influitive/apartment#309 , this configuration option doesn't have any effect now.
rpbaltazar
approved these changes
Jun 24, 2020
Merged
rpbaltazar
added a commit
that referenced
this pull request
Jun 26, 2020
Prepare Release - 2.7.0 # Enhancements - [Resolves #70] Rake tasks define methods on main - #75 - Add database and schema to active record log. Configurable, defaults to false to keep current behavior - #55 # Bugfixes - [Fixes #61] Fix database create in mysql - #76 # Chores - Remove depracated tld_length config option: tld_length was removed in influitive#309, this configuration option doesn't have any effect now. - #72 - Using [diffend.io proxy](https://diffend.io) to safely check required gems - Added [story branch](https://github.com/story-branch/story_branch) to the configuration - Using travis-ci to run rubocop as well, replacing github actions: github actions do not work in fork's PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tld_lengthhas no effect since influitive/apartment#309. Keep it there could be misleading (example).