Add /opt/homebrew to search path on Apple Silicon
#545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is default directory for Homebrew on Apple Silicon. Intel Mac installs into `/usr/local`, which is in our default path. Co-authored-by: Caleb Land <[email protected]>
andyundso
force-pushed
the
install-on-mac
branch
from
c467d2c
to
8011a96
Compare
|
as discussed with @aharpervc via mail, this is fix we like to include in the next release, so I'm going ahead and merge the branch. |
andyundso
added a commit
to andyundso/tiny_tds
that referenced
this pull request
Dec 3, 2023
On the corresponding PR (rails-sqlserver#545), everything looked fine and the build passed: https://app.circleci.com/pipelines/github/andyundso/tiny_tds/55/workflows/727c3150-0a8f-40a7-8a5f-9fd58e4e9428 However, once merged to master, the build failed since the executor was not available for the `tiny_tds` organization (see https://app.circleci.com/pipelines/github/rails-sqlserver/tiny_tds/18/workflows/47a0e21f-eda7-4901-a34b-ca4265f4f344/jobs/486). Although it would be helpful to have it, this commit removes the Apple Silicon build on CircleCI.
This was referenced Dec 3, 2023
andyundso
added a commit
to andyundso/tiny_tds
that referenced
this pull request
Apr 17, 2024
This is a test specifically for rails-sqlserver#545, which we were unable to run on CircleCI since we did not have paid runners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the same changes as in #531, but adds a job on CircleCI to verify the installation on Macs with Apple Silicon. I also made it conditional, so we do not look in
/opt/homebrewby default.