Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support complex context in Duktape by using eval #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maisumakun
Copy link

Just like ExecJS::ExternalRuntime::Context#call, not using Duktape's #call_prop but simple eval will solve #45 .

I don't know if there might be any side effects for this change, but it seems working.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@judofyr
Copy link
Contributor

judofyr commented May 29, 2018

@rafaelfranca Any progress on this?

@rafaelfranca
Copy link
Member

It is missing tests, so it is hard to assert it is actually doing what it should

@judofyr
Copy link
Contributor

judofyr commented May 30, 2018

I opened #76 to start a proper discussion around how to handle this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants