Fix detection for .mdb and .accdb files #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixeltrix
reviewed
May 17, 2021
|
|
||
| Marcel::MimeType.extend( | ||
| "application/vnd.ms-access", | ||
| extensions: %w( mdb accdb ), |
There was a problem hiding this comment.
@gmcgibbon I missed this - should mde and accde be in this list too? They're the compiled versions of mdb and accdb files.
There was a problem hiding this comment.
We could add those extensions, but it also depends what the hexdumped contents are for magic detection. I'll try playing with a trial of MS access to see if I can get more fixtures to test out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#44
Fixes magic and name detection for mdb and accdb files. Marcel 0.3.3 detected mdb files as
application/vnd.ms-access, which is restored. However, accdb was previouslyapplication/octet-stream. This patch also registers support for this extension with correct magic detection. If youhexdump -Caccess files you'll find\x00\x01\x00\xStandard Jet DBor\x00\x01\x00\xStandard ACE DBas a prefix, which previously got caught in our magic override for TTFs:Marcel::MimeType.extend "font/ttf", magic: [[0, "\x00\x01\x00\x00"]], extensions: %w( ttf ttc ).