Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if response status is unprocessableEntity #31

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Check if response status is unprocessableEntity #31

merged 2 commits into from
Aug 12, 2021

Conversation

olimart
Copy link
Contributor

@olimart olimart commented Aug 11, 2021

This PR adds a convenient helper to check for unprocessableEntity response status.

I bet we don't want to add a helper for each status code but this is motivated by the fact that Rails now returns 422 status code by default for form submission with error rails/rails#41026

So, we can legitimately expect doing this kind of check more often.

@marcelolx
Copy link
Collaborator

Can you fix the linting issue?

@olimart
Copy link
Contributor Author

olimart commented Aug 12, 2021

Can you fix the linting issue?

Done. I think you need to approve the run of CI.

@marcelolx marcelolx merged commit 7179454 into rails:main Aug 12, 2021
@marcelolx
Copy link
Collaborator

Thanks!

@olimart olimart deleted the patch-1 branch August 12, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants