Allow lists in query strings #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dphaener
force-pushed
the
allow-lists-in-query-strings
branch
from
e872bb0
to
107ea04
Compare
There are use cases where you may want to add an array of values to a query string. I.E. `ids[]=1&ids[]=2`. Previously the `mergeEntries` function was simply replacing any item in the search params with an identical name. This had the effect of only including the final entry in the params. This updates the `mergeEntires` function to just do an append rather than a replace if the entry name contains `[]`.
dphaener
force-pushed
the
allow-lists-in-query-strings
branch
from
107ea04
to
096923b
Compare
|
thanks @dphaener! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are use cases where you may want to add an array of values to a query string. I.E.
ids[]=1&ids[]=2.Previously the
mergeEntriesfunction was simply replacing any item in the search params with an identical name. This had the effect of only including the final entry in the params.This updates the
mergeEntiresfunction to just do an append rather than a replace if the entry name contains[].