Allow credentials option to be set #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t27duck
force-pushed
the
credential_option
branch
from
227f252
to
92f5fe5
Compare
Right now, the credentials option for the request object is locked to `same-origin`. `omit` and `include` are two additional valid options. This allows the user to set the value through the options object. If not set, we still default to `same-origin`.
t27duck
force-pushed
the
credential_option
branch
from
92f5fe5
to
a7a78e3
Compare
|
Thank you for working on this @t27duck! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #55
Right now, the credentials option for the request object is locked to
same-origin.omitandincludeare two additional valid options.This allows the user to set the value through the options object. If not set, we still default to
same-origin.