Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically active script response #72

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Automatically active script response #72

merged 4 commits into from
Sep 3, 2024

Conversation

songjiz
Copy link
Contributor

@songjiz songjiz commented Apr 8, 2024

Fixes #48

KonnorRogers
KonnorRogers reviewed Aug 30, 2024
View reviewed changes
Copy link
Contributor

@KonnorRogers KonnorRogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont know if it matters, just some extra things to align with how UJS handles script responses.

src/fetch_response.js Outdated Show resolved Hide resolved
src/fetch_response.js Show resolved Hide resolved
@marcelolx marcelolx mentioned this pull request Sep 3, 2024
Merged
@marcelolx marcelolx merged commit 25324b0 into rails:main Sep 3, 2024
1 check passed
@INexizI INexizI mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KonnorRogers KonnorRogers KonnorRogers left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for responseKind js/script
3 participants
@songjiz @KonnorRogers @marcelolx