Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix Fetch to the Request and Response classes #8

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

marcelolx
Copy link
Collaborator

@marcelolx marcelolx commented Jun 4, 2021

As pointed in #3 the actual Request/Response classes clashes with the built-in classes.

Turbo has similar classes too and they are named FetchRequest/FetchResponse, to me I think that we can use the same names since Turbo doesn't export those classes.

Closes #3

As pointed in rails#3 the actual Request/Response classes clashes with the built-in classes from JS
@marcelolx marcelolx merged commit a4ba4ac into rails:main Jun 4, 2021
@marcelolx marcelolx deleted the rename-classes branch June 4, 2021 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overriding Request and Response built-ins
1 participant