Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rake version 13.2 or higher to suppress ostruct warnings #811

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

yahonda
Copy link
Member

@yahonda yahonda commented Oct 22, 2024

This commit bumps the required Rake version to suppress the following warnings:

$ ruby -v
ruby 3.4.0dev (2024-10-21T16:48:53Z master 5131fb5dbe) +PRISM [x86_64-linux]
$ bundle exec rake 2>&1 |grep -i ostruct
ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.
/home/yahonda/.rbenv/versions/trunk/lib/ruby/gems/3.4.0+0/gems/rake-12.3.3/lib/rake/rake_test_loader.rb:2: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.
./home/yahonda/src/github.com/rails/sprockets/lib/rake/sprocketstask.rb:2: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.

This commit bumps the required Rake version to suppress the following warnings:

```ruby
$ ruby -v
ruby 3.4.0dev (2024-10-21T16:48:53Z master 5131fb5dbe) +PRISM [x86_64-linux]
$ bundle exec rake 2>&1 |grep -i ostruct
ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.
/home/yahonda/.rbenv/versions/trunk/lib/ruby/gems/3.4.0+0/gems/rake-12.3.3/lib/rake/rake_test_loader.rb:2: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.
./home/yahonda/src/github.com/rails/sprockets/lib/rake/sprocketstask.rb:2: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.
```

- Rake v13.2.0 does not depend on OpenStruct
https://github.com/ruby/rake/releases/tag/v13.2.0
ruby/rake#545

- Ruby 3.4.0dev emits OpenStruct warnings
https://bugs.ruby-lang.org/issues/20309
ruby/ruby#10428
@yahonda yahonda changed the title Bump rake version 13 or higher to suppress ostruct warnings Bump rake version 13.2 or higher to suppress ostruct warnings Oct 22, 2024
@yahonda yahonda merged commit ceac1ce into rails:main Oct 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants