Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow running readline specs in isolation #791

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Allow running readline specs in isolation #791

merged 3 commits into from
Jun 17, 2022

Conversation

deivid-rodriguez
Copy link
Contributor

Plus other minor improvements since I was at it.

@deivid-rodriguez deivid-rodriguez mentioned this pull request Jun 16, 2022
Merged
timdiggins
timdiggins reviewed Jun 16, 2022
View reviewed changes
Copy link
Contributor

@timdiggins timdiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just as a double check, I've validated on my machine that this does the trick

(on main, I get an error when I run bundle exec rspec spec/line_editor_spec.rb, whereas on this branch it succeeds).

@rafaelfranca rafaelfranca marked this pull request as ready for review June 17, 2022 00:07
@rafaelfranca rafaelfranca merged commit d092549 into rails:main Jun 17, 2022
@deivid-rodriguez deivid-rodriguez deleted the allow-running-readline-specs-in-isolation branch June 17, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdiggins timdiggins timdiggins left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deivid-rodriguez @timdiggins @rafaelfranca