Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EOL for Rails < 5.2 and Ruby < 2.3.0 #2415

Merged
merged 10 commits into from
Mar 20, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 8 additions & 21 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,22 +1,15 @@
language: ruby
dist: xenial
before_install:
- gem install rubygems-update -v 3.0.6 && update_rubygems
# Rails 4.2 doesn't support bundler 2.0, so we need to lock bundler to
# v1.17.3. This is just for Ruby 2.5 which ships with bundler 2.x on Travis
# CI while Ruby 2.6 does not.
# https://github.com/travis-ci/travis-rubies/issues/57#issuecomment-458981237
- yes | rvm @global do gem install bundler -v 1.17.3 || true
- gem install rubygems-update && update_rubygems
- yes | rvm @global do gem install bundler -v 2.1.4 || true
rvm:
- 2.3.8
- 2.4.6
- 2.4.9
- 2.5.5
- 2.6.3
- 2.6.5
- 2.7.0
- ruby-head
gemfile:
- gemfiles/Gemfile-rails.4.2.x
- gemfiles/Gemfile-rails.5.0.x
- gemfiles/Gemfile-rails.5.1.x
- gemfiles/Gemfile-rails.5.2.x
- gemfiles/Gemfile-rails.6.0.x
- gemfiles/Gemfile-rails-edge
Expand All @@ -28,7 +21,7 @@ cache:

install:
- bundle install --jobs 3 --retry 3
- nvm install 10
- nvm install 12
- node -v
- npm i -g yarn
- yarn
Expand All @@ -42,15 +35,9 @@ matrix:
- gemfile: gemfiles/Gemfile-rails-edge
- rvm: ruby-head
exclude:
- rvm: 2.3.8
gemfile: gemfiles/Gemfile-rails-edge
- rvm: 2.4.6
- rvm: 2.4.9
gemfile: gemfiles/Gemfile-rails-edge
- rvm: 2.5.5
gemfile: gemfiles/Gemfile-rails-edge
- rvm: ruby-head
gemfile: gemfiles/Gemfile-rails.4.2.x
- rvm: 2.3.8
gemfile: gemfiles/Gemfile-rails.6.0.x
- rvm: 2.4.6
- rvm: 2.4.9
gemfile: gemfiles/Gemfile-rails.6.0.x
4 changes: 2 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ PATH
remote: .
specs:
webpacker (4.2.2)
activesupport (>= 4.2)
activesupport (>= 5.2)
rack-proxy (>= 0.6.1)
railties (>= 4.2)
railties (>= 5.2)
semantic_range (>= 2.3.0)

GEM
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ in which case you may not even need the asset pipeline. This is mostly relevant

## Prerequisites

* Ruby 2.3+
* Rails 4.2+
* Ruby 2.4+
* Rails 5.2+
* Node.js 10.13.0+
* Yarn 1.x+

Expand Down
9 changes: 0 additions & 9 deletions gemfiles/Gemfile-rails.4.2.x

This file was deleted.

9 changes: 0 additions & 9 deletions gemfiles/Gemfile-rails.5.0.x

This file was deleted.

9 changes: 0 additions & 9 deletions gemfiles/Gemfile-rails.5.1.x

This file was deleted.

8 changes: 4 additions & 4 deletions webpacker.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ Gem::Specification.new do |s|
"changelog_uri" => "https://github.com/rails/webpacker/blob/v#{Webpacker::VERSION}/CHANGELOG.md"
}

s.required_ruby_version = ">= 2.3.0"
s.required_ruby_version = ">= 2.4.0"

s.add_dependency "activesupport", ">= 4.2"
s.add_dependency "railties", ">= 4.2"
s.add_dependency "rack-proxy", ">= 0.6.1"
s.add_dependency "activesupport", ">= 5.2"
s.add_dependency "railties", ">= 5.2"
s.add_dependency "rack-proxy", ">= 0.6.1"
s.add_dependency "semantic_range", ">= 2.3.0"

s.add_development_dependency "bundler", ">= 1.3.0"
Expand Down