Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play 3.0 compatibility #123

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

russellremple
Copy link
Contributor

Proposed changes

Add Scala 2.13 and Scala 3 artifacts for the play-json version compatible with Play 3.0. (Play 3.0 uses play-json 3.0.)

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

No new tests, just a new set project that runs existing shared weejson tests.

@russellremple
Copy link
Contributor Author

Since this is a very small change with zero impact to existing artifacts, I'm going to merge it without approvals.

@russellremple russellremple merged commit ed23e6c into rallyhealth:v1 Nov 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant