Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving and loading keypoints #45

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Saving and loading keypoints #45

merged 2 commits into from
Sep 11, 2023

Conversation

BAILOOL
Copy link
Collaborator

@BAILOOL BAILOOL commented Sep 8, 2023

Saving and loading detected keypoints allows to save time on rerunning the calibration.

Calibration time per sequence on my laptop:

Real Sequences w/o caching w/ caching
Seq00_Stereo_vision 591s 32s
Seq01_Non-overlapping 1519s 113s
Seq02_Overlapping_multicamera 261s 70s
Seq03_hybrid 262s 124s
Seq04_Converging_vision 1946s 149s
Seq05_Non_overlapping_6Cam 581s 91s
Blender Sequences w/o caching w/ caching
Scenario1 17s <1s
Scenario2 22s 9s
Scenario3 82s 36s
Scenario4 68s 36s
Scenario5 85s 40s

@BAILOOL BAILOOL added the enhancement New feature or request label Sep 8, 2023
@BAILOOL BAILOOL self-assigned this Sep 8, 2023
@rameau-fr
Copy link
Owner

Seems all good to me, we should not forget to update the README to warn the user that the keypoints are saved and that they can be loaded etc. Also do we need to rewrite all our configuration file?

@rameau-fr rameau-fr marked this pull request as ready for review September 9, 2023 01:43
@BAILOOL BAILOOL marked this pull request as draft September 9, 2023 05:45
@BAILOOL BAILOOL marked this pull request as ready for review September 9, 2023 07:05
@BAILOOL BAILOOL changed the title WIP: Saving and loading keypoints Saving and loading keypoints Sep 9, 2023
@rameau-fr
Copy link
Owner

Seems all good to me!

@BAILOOL BAILOOL merged commit 3480f6a into master Sep 11, 2023
1 check passed
@BAILOOL BAILOOL deleted the feature/keypoint-caching branch September 14, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants