Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple clients via features #129

Merged
merged 98 commits into from
Oct 18, 2020
Merged

Multiple clients via features #129

merged 98 commits into from
Oct 18, 2020

Commits on Aug 29, 2020

  1. First attempt with Deref

    @marioortizmanero
    marioortizmanero committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    e4f85f8 View commit details
    Browse the repository at this point in the history

  2. Formatting and Cargo.toml fix

    @marioortizmanero
    marioortizmanero committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    d0e7a5f View commit details
    Browse the repository at this point in the history

  3. Implemented run_blocking macro

    @marioortizmanero
    marioortizmanero committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    279c138 View commit details
    Browse the repository at this point in the history

  4. Fix tokio import for tests, small cleanup

    @marioortizmanero
    marioortizmanero committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    7532b3f View commit details
    Browse the repository at this point in the history

  5. Implemented macro for a single function

    @marioortizmanero
    marioortizmanero committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    e783eae View commit details
    Browse the repository at this point in the history

  6. Now with docs too

    @marioortizmanero
    marioortizmanero committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    d3e821c View commit details
    Browse the repository at this point in the history

  7. Single impl block, documentation

    @marioortizmanero
    marioortizmanero committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    9c783dd View commit details
    Browse the repository at this point in the history

  8. More clear formatting

    @marioortizmanero
    marioortizmanero committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    675aeb7 View commit details
    Browse the repository at this point in the history

  9. Applied to all endpoints with a vim macro!

    @marioortizmanero
    marioortizmanero committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    578c13b View commit details
    Browse the repository at this point in the history

  10. Fixed docstrings

    @marioortizmanero
    marioortizmanero committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    2c29637 View commit details
    Browse the repository at this point in the history

  11. Added changelog entry

    @marioortizmanero
    marioortizmanero committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    f920314 View commit details
    Browse the repository at this point in the history

  12. Cleanup, failing miserably at generic paramters like Into<Option<u32>>

    @marioortizmanero
    marioortizmanero committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    f5fbb68 View commit details
    Browse the repository at this point in the history

  13. Removing the 'Into<Option<T>>' does work, not sure if valid

    @marioortizmanero
    marioortizmanero committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    2387313 View commit details
    Browse the repository at this point in the history

  14. Added comment before endpoint macro

    @marioortizmanero
    marioortizmanero committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    fef8801 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2020

  1. Merge with master

    @marioortizmanero
    marioortizmanero committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    dfda2f7 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2020

  1. Fixed merge conflict

    @marioortizmanero
    marioortizmanero committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    f236ce0 View commit details
    Browse the repository at this point in the history

  2. Added to changelog

    @marioortizmanero
    marioortizmanero committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    e352947 View commit details
    Browse the repository at this point in the history

  3. Prettier macro

    @marioortizmanero
    marioortizmanero committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    5124dbb View commit details
    Browse the repository at this point in the history

  4. Second attempt at cleaning up the blocking module

    @marioortizmanero
    marioortizmanero committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    f10c963 View commit details
    Browse the repository at this point in the history

  5. Brief top-level documentation

    @marioortizmanero
    marioortizmanero committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    95c5293 View commit details
    Browse the repository at this point in the history

  6. Cleaned up dependencies

    @marioortizmanero
    marioortizmanero committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    36df1c8 View commit details
    Browse the repository at this point in the history

  7. Fixed http client function signatures

    @marioortizmanero
    marioortizmanero committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    9c10893 View commit details
    Browse the repository at this point in the history

  8. Great progress, WIP rewrite of fetch_access_token

    @marioortizmanero
    marioortizmanero committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    68e2ea0 View commit details
    Browse the repository at this point in the history

  9. Refresh access token

    @marioortizmanero
    marioortizmanero committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    74b026b View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2020

  1. Getting it to compile

    @marioortizmanero
    marioortizmanero committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    c596ede View commit details
    Browse the repository at this point in the history

  2. General errors and small fixes

    @marioortizmanero
    marioortizmanero committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    e3061df View commit details
    Browse the repository at this point in the history

  3. Working OAuth, documentation and initial ureq

    @marioortizmanero
    marioortizmanero committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    dfb1014 View commit details
    Browse the repository at this point in the history

  4. Improved endpoints, now with json!

    @marioortizmanero
    marioortizmanero committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    1098cda View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2020

  1. Trying to fix requests

    @marioortizmanero
    marioortizmanero committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    b77eb08 View commit details
    Browse the repository at this point in the history

  2. Proper content types

    @marioortizmanero
    marioortizmanero committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    4bbc2e6 View commit details
    Browse the repository at this point in the history

  3. Fix reqwest, base ureq impl

    @marioortizmanero
    marioortizmanero committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    67884f5 View commit details
    Browse the repository at this point in the history

  4. Fixed relative URLs

    @marioortizmanero
    marioortizmanero committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    60f1a0f View commit details
    Browse the repository at this point in the history

  5. Small fix and cargo fmt

    @marioortizmanero
    marioortizmanero committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    2f633a5 View commit details
    Browse the repository at this point in the history

  6. Update changelog

    @marioortizmanero
    marioortizmanero committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    401cb2b View commit details
    Browse the repository at this point in the history

  7. Remove Token::token_type

    @marioortizmanero
    marioortizmanero committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    f5fb3a3 View commit details
    Browse the repository at this point in the history

  8. Updated basic examples

    @marioortizmanero
    marioortizmanero committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    1362b47 View commit details
    Browse the repository at this point in the history

  9. Fixed some tests

    @marioortizmanero
    marioortizmanero committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    099426d View commit details
    Browse the repository at this point in the history

  10. api_urls module

    @marioortizmanero
    marioortizmanero committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    29aab9a View commit details
    Browse the repository at this point in the history

  11. Fixed "Bad Request" 

    Turns out you can't use Value::Null for empty parameters...  This commit
simply makes the payload optional for the reqwest client.
    @marioortizmanero
    marioortizmanero committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    bff6a1d View commit details
    Browse the repository at this point in the history

  12. Fixed for ureq as well

    @marioortizmanero
    marioortizmanero committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    466a4d3 View commit details
    Browse the repository at this point in the history

  13. Fix tests, realize that it still doesn't work

    @marioortizmanero
    marioortizmanero committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    04166d7 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2020

  1. Moved Spotify OAuth logic to oauth2 module

    @marioortizmanero
    marioortizmanero committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    0443226 View commit details
    Browse the repository at this point in the history

  2. Raw string literals and import fix

    @marioortizmanero
    marioortizmanero committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    be01e05 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. Initial fix for Error 400: Bad Request

    @marioortizmanero
    marioortizmanero committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    6348d01 View commit details
    Browse the repository at this point in the history

  2. Fix tests

    @marioortizmanero
    marioortizmanero committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    3763b33 View commit details
    Browse the repository at this point in the history

  3. Some nicer endpoints

    @marioortizmanero
    marioortizmanero committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    b7f7fee View commit details
    Browse the repository at this point in the history

  4. Fix for 'Length Required' error

    @marioortizmanero
    marioortizmanero committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    b3db5d3 View commit details
    Browse the repository at this point in the history

  5. cargo fmt, add_item_to_queue now requires Premium

    @marioortizmanero
    marioortizmanero committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    4223a2a View commit details
    Browse the repository at this point in the history

  6. Fix Continuous Integration

    @marioortizmanero
    marioortizmanero committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    c47a404 View commit details
    Browse the repository at this point in the history

  7. Tests both with sync and async clients

    @marioortizmanero
    marioortizmanero committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    2a04a03 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2020

  1. Fix lint error

    @ramsayleung
    ramsayleung committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    57aa70d View commit details
    Browse the repository at this point in the history

  2. reformat code with cargo fmt.

    @ramsayleung
    ramsayleung committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    87c91d4 View commit details
    Browse the repository at this point in the history

  3. Fix lint error.

    @ramsayleung
    ramsayleung committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    f5a3064 View commit details
    Browse the repository at this point in the history

  4. Added CI for clippy with client-ureq, fixed features

    @marioortizmanero
    marioortizmanero committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    0482831 View commit details
    Browse the repository at this point in the history

  5. Fix tests

    @marioortizmanero
    marioortizmanero committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    a496040 View commit details
    Browse the repository at this point in the history

  6. Ignore clippy warnings for now related to the bug

    @marioortizmanero
    marioortizmanero committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    54fd014 View commit details
    Browse the repository at this point in the history

  7. Customizing ureq TLS as well

    @marioortizmanero
    marioortizmanero committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    381d466 View commit details
    Browse the repository at this point in the history

  8. Update documentation

    @marioortizmanero
    marioortizmanero committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    40781d3 View commit details
    Browse the repository at this point in the history

  9. Update document about async/blocking version, and how to build rspotify.

    @ramsayleung
    ramsayleung committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    8693218 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'multiple-clients' of github.com:ramsayleung/rspotify in… 

    …to multiple-clients
    @ramsayleung
    ramsayleung committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    32dff3a View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2020

  1. Update document.

    @ramsayleung
    ramsayleung committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    b91ce5e View commit details
    Browse the repository at this point in the history

  2. Update document again.

    @ramsayleung
    ramsayleung committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    7f89adc View commit details
    Browse the repository at this point in the history

  3. Fix all tests in a clumsy way and update example in README.

    @ramsayleung
    ramsayleung committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    2cc2192 View commit details
    Browse the repository at this point in the history

  4. reformat code with cargo fmt.

    @ramsayleung
    ramsayleung committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    3e5fc5a View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. Properly fix tests, improve Token 

    * Removes the fake playlist ID test
* Fixes the tests properly by not sharing the credentials for the tests.
Tests should be isolated anyway so it should be an improvement. This has
also been applied to the OAuth tests.
* Some improvements to make `Token` more modular
* Export `DEFAULT_API_PREFIX` and `DEFAULT_CACHE_PATH` as public
variables for anyone to read.
* `is_scope_subset` doesn't need &mut
* `Spotify::save_token_info` -> `Spotify::write_token_cache`
    @marioortizmanero
    marioortizmanero committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    6adde82 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. Using url::Url::parse_with_params

    @marioortizmanero
    marioortizmanero committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    c816dc8 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2020

  1. Should fix CI

    @marioortizmanero
    marioortizmanero committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    ee5b0c8 View commit details
    Browse the repository at this point in the history

  2. Update maybe-async to avoid parenthesis warnings

    @marioortizmanero
    marioortizmanero committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    f9c8304 View commit details
    Browse the repository at this point in the history

  3. Revert to optional payload

    @marioortizmanero
    marioortizmanero committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    24ebb68 View commit details
    Browse the repository at this point in the history

  4. WIP refactor to http client internals

    @marioortizmanero
    marioortizmanero committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    a1ac650 View commit details
    Browse the repository at this point in the history

  5. Progress for ureq

    @marioortizmanero
    marioortizmanero committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    f4547b4 View commit details
    Browse the repository at this point in the history

  6. Fixed ureq empty parameters

    @marioortizmanero
    marioortizmanero committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    116d6b2 View commit details
    Browse the repository at this point in the history

  7. First fix for ureq tests

    @marioortizmanero
    marioortizmanero committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    d2f18a9 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2020

  1. Back to HashMap for GET requests...

    @marioortizmanero
    marioortizmanero committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    4ddeda5 View commit details
    Browse the repository at this point in the history

  2. Cleanup ureq, fix README wording, blocking -> ureq

    @marioortizmanero
    marioortizmanero committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    b289100 View commit details
    Browse the repository at this point in the history

  3. Example snippets now break, so I removed it

    @marioortizmanero
    marioortizmanero committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    102e2c0 View commit details
    Browse the repository at this point in the history

  4. Formatting

    @marioortizmanero
    marioortizmanero committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    8fb2db1 View commit details
    Browse the repository at this point in the history

  5. Changed the default limit by mistake

    @marioortizmanero
    marioortizmanero committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    57f28ec View commit details
    Browse the repository at this point in the history

  6. unnecessary change of 'get_authorize_url' name

    @marioortizmanero
    marioortizmanero committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    496ffe9 View commit details
    Browse the repository at this point in the history

  7. consistency: get_cached_token -> read_token_cache

    @marioortizmanero
    marioortizmanero committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    a98c4ec View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2020

  1. Improving the changelog

    @marioortizmanero
    marioortizmanero committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    d7ec619 View commit details
    Browse the repository at this point in the history

  2. Update webapp example.

    @ramsayleung
    ramsayleung committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    596ef65 View commit details
    Browse the repository at this point in the history

  3. Revert get_token, get_creds, get_oauth to public(in crate).

    @ramsayleung
    ramsayleung committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    aedcb0d View commit details
    Browse the repository at this point in the history

  4. Optimize code by clippy hint.

    @ramsayleung
    ramsayleung committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    d55c4a6 View commit details
    Browse the repository at this point in the history

  5. cargo fmt

    @marioortizmanero
    marioortizmanero committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    4d793f4 View commit details
    Browse the repository at this point in the history

  6. Update webapp example.

    @ramsayleung
    ramsayleung committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    8cbadf3 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'multiple-clients' of github.com:ramsayleung/rspotify in… 

    …to multiple-clients
    @ramsayleung
    ramsayleung committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    da98dab View commit details
    Browse the repository at this point in the history

  8. Excellent documentation now!

    @marioortizmanero
    marioortizmanero committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    9bdec0a View commit details
    Browse the repository at this point in the history

  9. parse_response_code moved to oauth2.rs

    @marioortizmanero
    marioortizmanero committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    edfd275 View commit details
    Browse the repository at this point in the history

  10. ApiError is now APIError for consistency

    @marioortizmanero
    marioortizmanero committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    59929f1 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2020

  1. Fix typo

    @ramsayleung
    ramsayleung committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    7ca2755 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2020

  1. Merge branch 'master' into multiple-clients

    @marioortizmanero
    marioortizmanero committed Oct 17, 2020
    Configuration menu
    Copy the full SHA
    3f3a460 View commit details
    Browse the repository at this point in the history

  2. url crate in parse_response_code

    @marioortizmanero
    marioortizmanero committed Oct 17, 2020
    Configuration menu
    Copy the full SHA
    6cbe261 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2020

  1. test_parse_response_code

    @marioortizmanero
    marioortizmanero committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    2461f4f View commit details
    Browse the repository at this point in the history

  2. constants for headers

    @marioortizmanero
    marioortizmanero committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    4f3c48a View commit details
    Browse the repository at this point in the history

  3. Remove some TODOs and pub(in crate) until removed

    @marioortizmanero
    marioortizmanero committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    2fbf3d5 View commit details
    Browse the repository at this point in the history

  4. Cargo.toml cleanup

    @marioortizmanero
    marioortizmanero committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    1a4aff6 View commit details
    Browse the repository at this point in the history

  5. fixed http::headers::SHOW_DIALOG

    @marioortizmanero
    marioortizmanero committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    c2865a5 View commit details
    Browse the repository at this point in the history