[Auth restructure 4] Fix examples/tests/docs and CI #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm currently updating the changelog to include a small guide on how to upgrade to the new version. I've opened the #218 issue for those with questions regarding the update, and I'll mention said issue in the changelog as well. |
|
Is there any required order for this [Auth restructure part N] PR to merge? Does one PR reply to another? If not, is it fine to merge individually when one PR review approves and CI pass? |
|
You can merge as you like, GitHub should handle it correctly. Though the safest way to go is first 4, then 3, then 2, then 1, then separate-crates. |
ramsayleung
reviewed
Jun 19, 2021
ramsayleung
approved these changes
Jun 19, 2021
|
Looks good to me, merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 4 of #207's split up. This fixes many other things related to the rewrite: the examples, tests, documentation, and CI.
The main library should pass the tests & CI, and the examples should work after this PR.