-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix refreshing token #255
Fix refreshing token #255
Conversation
Fix IDs v4
Fixes cached tokens
Over in spotify-tui, I implemented the new `start_context_playback` and hit "request unauthorized" every time. Looking at the code, the previous `put` call was not receiving the auth headers. This fix here is to use the `endpoint_put` method which seems to abstract passing in the headers?
This reverts commit 5c0f57c.
Fix oauth set token and fix unauthorized playback control
Ok so I've got it compiling without needing lots of |
What do you think about renaming |
While I'm at it I've also merged master onto this branch and fixed all the conflicts |
Well, this has become a mess. I'm having lots of trouble merging master... Would you mind re-doing the PR with the current It shouldn't be too hard, you can copy-paste most stuff (the examples and the |
Since everything else has been merged, we could continue work on #224 :)
Do you mean I should create a new PR from the current |
Yes. Unfortunately the merge conflicts are super hard to deal with, it'll be easier to do it from scratch in my opinion. Then you can add what I suggested at #255 to fix our problem. |
Did you run the |
That most likely means that there's unbounded recursivity somewhere, i. e. the auto reauth function calls something which calls the auto reauth again. I'll take a look later. |
Description
This fixes #224 by creating a wrapper for
Mutex
so that it's the same for both sync and async programming, similarly to how pagination works.