Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not append always empty restore_key #216

Merged
merged 1 commit into from
Dec 28, 2021
Merged

Conversation

szepeviktor
Copy link
Contributor

Description

It was just initialized: restore_key=()

PR checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #216 (e1277c4) into v2 (ef0ac57) will decrease coverage by 1.61%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2     #216      +/-   ##
==========================================
- Coverage   88.70%   87.09%   -1.62%     
==========================================
  Files           5        5              
  Lines         124      124              
==========================================
- Hits          110      108       -2     
- Misses         14       16       +2     
Impacted Files Coverage Δ
bin/cache_key.sh 76.92% <100.00%> (ø)
bin/composer_paths.sh 85.00% <0.00%> (-5.00%) ⬇️

Copy link
Owner

@ramsey ramsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is leftover from when I was creating multiple restore keys, which I might revisit in the future, but it was causing too many cache collisions.

@ramsey ramsey merged commit 6e86502 into ramsey:v2 Dec 28, 2021
@szepeviktor szepeviktor deleted the patch-2 branch December 28, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants