Allow for settings to override GEONAMES_DUMPS_URL and GEONAMES_DATA #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…they match then correctly close existing file and also close the web file. Print a message to inform the user too.
…file downloaded so far. Ideally this should be on a single line but \r just seems to delay output until all the file has downloaded.
…he progress it printed, X backspace chars are printed and then flushed. Without this either the output would be buffered until the download was finished or new lines would appear from somewhere.
…her files. Only the main 'allCountries' file is downloaded since it's only 8.8MB which should be small enough as it is. Also include an option to disable the postalcodes.
…ormat. All the data from the postal code dump is kept.
the columns that are mentioned in http://www.geonames.org/export/zip/readme.txt
All fields should be imported from the original file.
…curacy figures. If the long or lat are missing then ignore the row. If accuracy is missing then assume that it's 0 (zero)
…e Alternate names table.
…the values from the compress file like the download command does.
…of zcat which doesn't work in POSIX mode correctly (appending a .Z to the filename by default).
Conflicts: geonames/management/commands/load_geonames.py setup.py
Removed the custom BigIntegerField since Django >= 1.2 has its own.
Conflicts: .gitignore geonames/management/commands/compress_geonames.py geonames/management/commands/download_geonames.py geonames/management/commands/load_geonames.py
Missing import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the appropriate way to override an app-specific setting.. I'd like to use your download_geonames but not keep my data in my virtualenv dir.