Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Node Exporter to 1.18.1 #1251

Closed
wants to merge 3 commits into from

Conversation

aiyengar2
Copy link
Contributor

@aiyengar2 aiyengar2 commented Jun 8, 2021

The first commit has actual changes applied on the original base. All changes should be viewed.

The second commit is the generated changes from switching the package.yaml. Only the package.yaml really needs to be checked.

The third commit is make charts.

Related Issue: rancher/rancher#32519

@aiyengar2 aiyengar2 requested a review from jiaqiluo June 8, 2021 23:51
Copy link
Member

@jiaqiluo jiaqiluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

commit: 78d1219306eaca5be1d8bab84445d0489e073840
packageVersion: 1
commit: a05f7b8888d6174827b815aa097d64b94f00af3e
packageVersion: 01
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not an issue. Since the value of packageVersion is treated as an integer, so 1 == 01, but I can see that you try to indicate that the value could be 2-dight.

@aiyengar2 aiyengar2 mentioned this pull request Jun 15, 2021
1 task
@aiyengar2
Copy link
Contributor Author

Close in favor of #1274

@aiyengar2 aiyengar2 closed this Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants