Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of tests for config mapstructure #102

Merged
merged 4 commits into from
Aug 1, 2022
Merged

Couple of tests for config mapstructure #102

merged 4 commits into from
Aug 1, 2022

Conversation

Itxaka
Copy link
Contributor

@Itxaka Itxaka commented Aug 1, 2022

So we dont drop them in the future

Signed-off-by: Itxaka [email protected]

So we dont drop them in the future

Signed-off-by: Itxaka <[email protected]>
@Itxaka Itxaka requested a review from a team August 1, 2022 12:08
@Itxaka Itxaka enabled auto-merge (squash) August 1, 2022 12:08
Copy link
Contributor

@kkaempf kkaempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except for "os2", lgtm !

pkg/config/config_suite_test.go Outdated Show resolved Hide resolved
@Itxaka Itxaka merged commit 5b9606f into main Aug 1, 2022
@ldevulder ldevulder deleted the test_marshall branch August 3, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants