Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chart] only add default-registry if specified #128

Merged
merged 3 commits into from
Aug 10, 2022

Conversation

Itxaka
Copy link
Contributor

@Itxaka Itxaka commented Aug 10, 2022

If its empty let the operator set the default value instead of passing a
flag with an empty value

Signed-off-by: Itxaka [email protected]

If its empty let the operator set the default value instead of passing a
flag with an empty value

Signed-off-by: Itxaka <[email protected]>
@Itxaka Itxaka added the area/chart Chart related changes label Aug 10, 2022
Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!
The e2e failure should be due to #129

@Itxaka Itxaka enabled auto-merge (squash) August 10, 2022 10:25
@Itxaka Itxaka merged commit 7e71181 into rancher:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/chart Chart related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants