Add extra labels with smbios data

[Itxaka]

Now that we get the smbios data properly, we can add extra labels to the
inventory based on that smbios data.

This could be helpful to identify groups of machines in big deployments
and adds extra info to the inventory so we can search using selectors
via kubectl.

Signed-off-by: Itxaka [email protected]

[Itxaka]

final labels ends like this:

$ kubectl describe machineinventory --all-namespaces                                              
Name:         my-machine
Namespace:    fleet-default
Labels:       cpuCore=1
              cpuFamily=other
              cpuManufacturer=qemu
              cpuThreads=1
              location=europe
              manufacturer=qemu
              productName=standard-pc-q35-ich9-2009
              serialNumber=not-specified
              uuid=b6bd924f-ffd0-43cf-905b-102007aafe3a

[davidcassany]

Looks good to me 👍 Registering machine details looks like a good move to me, I agree this is likely to be useful in large deployments.

I just do not understand the naming start constraints and its change.

[davidcassany]

Why is required? I don't know from where this restriction came from, but I am wondering if relaxing it will cause issues.

[fgiudici]

I think it was used just to check if the label (was the name) had a valid first character, otherwise m is prepended.
Yep, this code is a bit cumbersome maybe it deserves a rework 😅

[davidcassany]

Then as a result of this change a name staring with a digit has no m prepended right? will it be an issue?

[fgiudici]

AFAIK no, kubernetes resource names and labels may start with a digit too

[Itxaka]

yep, this was done only with the machine name in mind, so the regex never expected to find a machine name starting with a digit :D

This is mostly due to protection against someone setting a machine name like -sdfa or an empty name ""

And yeah k8s names/labels are alphanumeric + - and . but not at the start or end -> https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names

[fgiudici]

Really geat idea, love this patch! ❤️