Add test for chart values #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Itxaka
force-pushed
the
chart_test_values
branch
4 times, most recently
from
8684742
to
d106fea
Compare
Quick check for values in the built chart so we dont break it again, especially on release Signed-off-by: Itxaka <[email protected]>
Itxaka
force-pushed
the
chart_test_values
branch
from
d106fea
to
54d850a
Compare
mudler
approved these changes
Jul 12, 2022
mjura
approved these changes
Jul 13, 2022
| run: | | ||
| REPO=$(helm show values ${{ steps.chart.outputs.chart_name }}|yq .image.repository) | ||
| TAG=$(helm show values ${{ steps.chart.outputs.chart_name }}|yq .image.tag) | ||
| if [ "$REPO" != "quay.io/costoolkit/elemental-operator" ];then |
There was a problem hiding this comment.
It seems that quay.io/costoolkit/elemental-operator is empty, are we going to build there images
There was a problem hiding this comment.
yep, on release, images tagged with a version should be pushed there, unfortunately we havent cut a release yet :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick check for values in the built chart so we dont break it again,
especially on release
We check that the REPO is set correctly on the built chart, and on release we also check the TAG
Signed-off-by: Itxaka [email protected]