Remove obsolete logic from former ros-installer #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #45 +/- ##
===========================================
- Coverage 40.37% 27.40% -12.97%
===========================================
Files 9 5 -4
Lines 701 343 -358
===========================================
- Hits 283 94 -189
+ Misses 398 247 -151
+ Partials 20 2 -18
Continue to review full report at Codecov.
|
|
Gonna strip out all commented code after checking it is functional, so that this is still a draft. Once verified we need a way to include free-form cloud-init data. For now I don't think we need to parse kernel command line parameters as part of the configuration (this was included former ros-installer), shouldn't be hard to include it though |
davidcassany
force-pushed
the
remove_unused_ros_installer_logic
branch
2 times, most recently
from
c538efc
to
88fe62b
Compare
Signed-off-by: David Cassany <[email protected]>
davidcassany
force-pushed
the
remove_unused_ros_installer_logic
branch
3 times, most recently
from
a288073
to
cd83443
Compare
Signed-off-by: David Cassany <[email protected]>
davidcassany
force-pushed
the
remove_unused_ros_installer_logic
branch
from
cd83443
to
3d94b19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Cassany [email protected]