-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add README to elemetal-operator helm chart #56
Conversation
Codecov Report
@@ Coverage Diff @@
## main #56 +/- ##
=======================================
Coverage 27.06% 27.06%
=======================================
Files 5 5
Lines 351 351
=======================================
Hits 95 95
Misses 250 250
Partials 6 6 Continue to review full report at Codecov.
|
I'm wondering how this makes sense with our splitter chart push. I.E. on this repo we push to our GitHub helm repo but on the readme we mention the opensuse OCI registry. I guess we should have a different reqdme here pointing to our GitHub resources and then add a different reqdme on the obs build? Also, would it be possible to generate the readme with some helm plugin that takes those parameters as flags maybe? That would be pretty cool and we could generate it as part of the chart build Also, docker push jobs doesn't work with forks, only with branches off the main repo so we can ignora that job for now 😀 |
chart/README.md
Outdated
| Key | Type | Default | Description | | ||
|-----|------|---------|-------------| | ||
| image.empty | string | `rancher/pause:3.1` | | | ||
| image.repository | string | `rancher/elemental-operator` | Source image for elemental-operator with repository name | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rancher/elemental would seem like the image is on dockerhub ... instead we have:
on github: quay.io/costoolkit/elemental-operator-ci
on OBS: registry.opensuse.org/isv/rancher/elemental/teal52/15.3/rancher/elemental-operator
should we put the full OBS path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I have provided for now path to quay.io
Or should we mention that the official release is on OBS (all as in the current README) and keep a separate "Dev" instructions detailing the installation from the github? |
9c288c6
to
765df11
Compare
That could also work, dev charts VS official charts, nice! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably we should add some more context, because we release the chart here on github, while we point to the OBS release in the README here. Anyway, I think this is a good start, we can improve this later.
LGTM, thanks @mjura !
No description provided.