review elemental installer env vars #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesco Giudici <[email protected]>
this requires rancher/elemental-cli#285 Signed-off-by: Francesco Giudici <[email protected]>
fgiudici
force-pushed
the
elemental_env_vars
branch
from
68c5004
to
566e756
Compare
fgiudici
changed the title
Root password and ssh keys are written in the cloud-config file. Since they are not need by the elemental installer avoid passing them in unchecked env vars. Signed-off-by: Francesco Giudici <[email protected]>
fgiudici
force-pushed
the
elemental_env_vars
branch
from
566e756
to
adb2dcc
Compare
Codecov Report
@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 27.06% 27.29% +0.23%
==========================================
Files 5 5
Lines 351 348 -3
==========================================
Hits 95 95
+ Misses 250 249 -1
+ Partials 6 4 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.