-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store registration yaml in installed system #71
Store registration yaml in installed system #71
Conversation
Signed-off-by: David Cassany <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #71 +/- ##
=======================================
Coverage 29.74% 29.74%
=======================================
Files 5 5
Lines 353 353
=======================================
Hits 105 105
Misses 244 244
Partials 4 4 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but if its only for the labels, shouldnt we just integrate that as part of the registration? we should have all the info needed to add labels already no? And the machineInventory should already be created? I think we should explore that afterwards but this works for now 👍
Yeah, I think the more general question is: the elemental-operator is just for installing the system or should be available after the install (e.g., for labels)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
You both are right indeed, it is not completely clear to me if it makes much sense running |
This PR ensures the bare minimum configuration to call
elemental-operator register
from the installed system is stored to the installed system during the installation.On installed system calling
elemental-operator register /oem/registration
will rerun the registration process without applying any change on the current system (no installation neither cloud-config download). Can be used to apply labels to machine inventories and similar operations.Related to rancher/elemental-cli#284 and #63
Signed-off-by: David Cassany [email protected]