[v1.6.x] Add managedosversion finalizer (#775 & #784) #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement ManagedOSVersion controller and finalizer Signed-off-by: Andrea Mazzotti <[email protected]> * Remove unused ManagedOSVersion Status Signed-off-by: Andrea Mazzotti <[email protected]> --------- Signed-off-by: Andrea Mazzotti <[email protected]> Co-authored-by: Francesco Giudici <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.6.x #782 +/- ##
=========================================
Coverage ? 57.75%
=========================================
Files ? 42
Lines ? 5175
Branches ? 0
=========================================
Hits ? 2989
Misses ? 1866
Partials ? 320 ☔ View full report in Codecov by Sentry. |
davidcassany
requested changes
Jun 26, 2024
There was a problem hiding this comment.
This backport must include #784 (or some equivalent solution)
* Block reinstall if crds are still pending to be deleted Signed-off-by: David Cassany <[email protected]>
anmazzotti
changed the title
Cherry picked into this PR. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #775 and #784