Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make /oem/registration the default configuration dir for elemental-operator client #81

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

davidcassany
Copy link
Contributor

Signed-off-by: David Cassany [email protected]

This commit uses /oem/registration as the default directory
to load configuration from in elemental-opertator register command

Signed-off-by: David Cassany <[email protected]>
@davidcassany davidcassany force-pushed the make_oem_registration_default_conf_dir branch from 274899a to a87eb51 Compare July 22, 2022 12:35
@davidcassany
Copy link
Contributor Author

As discussed in #76 (comment) this could be a better approach to support a simple elemental-operator register call within the installed system without having to provide any additional parameter.

Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,
probably at this point we should document clearly where the registration file is expected to live.
It is worth also to add the path to logs if no config file is found, let's do as part of #68

@davidcassany davidcassany merged commit cf20bc6 into main Jul 22, 2022
@davidcassany davidcassany deleted the make_oem_registration_default_conf_dir branch July 22, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants